Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving window position and/or size (using new window flags in WindowDesc) #3900

Closed
DorpsGek opened this issue Jun 24, 2010 · 3 comments
Closed
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

avk opened the ticket and wrote:

This patch provides ability to save window position and/or size when window closed and restore it when window is reopened.
This ability is switched on with new window default flags: WDF_SAVE_POS and WDF_SAVE_SIZE.
The examples for map window and bridge constructing window are added as a separated diffs.

Attachments

Reported version: other
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3900
@DorpsGek
Copy link
Member Author

Belugas wrote:

interesting idea


This comment was imported from FlySpray: https://bugs.openttd.org/task/3900#comment8591

@DorpsGek
Copy link
Member Author

avk wrote:

The actual version is attached. The following changes are made:

  1. Comments added - I see the great work to adjust comments and formatting the team doing :)
  2. Correctly processed the size of shaded windows - the unshaded_size stored instead of current size of a window.
  3. Position restoring added to Terraform and Transparency windows - because its have overrided OnInitialPosition methods.
  4. Window can be sticked by default if the new WDF_DEF_STICKY flag is set in window description.
  5. Window sticky flag is saved/restored if the new WDF_SAVE_STICKY flag is set in window description.
  6. Little trick added: window can be shaded on/off by double click on a window title (if it allows shading).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3900#comment8610

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/3900

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant