Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in remove road permission checker #3882

Closed
DorpsGek opened this issue Jun 16, 2010 · 2 comments
Closed

Regression in remove road permission checker #3882

DorpsGek opened this issue Jun 16, 2010 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Krille opened the ticket and wrote:

Versions:
trunk: 19991
1.0: 19938

* Consider the given savegame. You are the blue company, the full road crossing you see is owned by the yellow company.
* Select the autoroad tool and the remove tool.
* Now click the road crossing and drag to one of the neighbouring plain tiles.
* With trunk you'll notice that dragging SE or SW only shows the general error message that the road couldn't be removed. Dragging NE or NW tells that the road is owned by the other company using the window with the face.
* With 1.0 you'll get the window with the face in all four directions.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3882
@DorpsGek
Copy link
Member Author

Rubidium wrote:

The regression is caused by the command handling rewrite. Previously ownership tests would just simply overwrite the global error and now it will "just" return the error generated by the last failed removal.

I have to agree that the more serious error should be returned in all cases. In that case the drag rail removal is broken as well in a similar manner.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3882#comment8176

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 9, 2010

Terkhen closed the ticket.

Reason for closing: Fixed

In r20099.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3882

@DorpsGek DorpsGek closed this as completed Jul 9, 2010
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek