Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing grfs are not specified on crash by incompatible newgrfs #3791

Closed
DorpsGek opened this issue Apr 24, 2010 · 6 comments
Closed

Missing grfs are not specified on crash by incompatible newgrfs #3791

DorpsGek opened this issue Apr 24, 2010 · 6 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

perk11 opened the ticket and wrote:

When loading a savegame which has grfs which are missing, but grfs with the same ids are in player's newgrf folder a long error message is shown. The last sentence says "The missing NewGRFs are:", but it isn't followed by the lists of NewGRFs. And BTW the message is not localised.
I use Windows 7

Attachments

Reported version: 1.0.0
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/3791
@DorpsGek
Copy link
Member Author

perk11 wrote:

And yes, the message looks ugly with those line ends after the first word

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791#comment7934

@DorpsGek
Copy link
Member Author

perk11 wrote:

I've just realised that empty newgrfs list means that crash was not caused by NewGRF as I can understand. So if there are now newgrfs causing crash why should I read that long text? :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791#comment7935

@DorpsGek
Copy link
Member Author

perk11 wrote:

The reason of crash is patched version of OpenTTD (but I tell about the message)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791#comment7937

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Handling crashes is a tricky thing to do. A crash can have seriously corrupted the state of OpenTTD and as such we should do as little as possible while giving as much information as possible. This for example means we only look for missing NewGRFs once and not twice and as such have a somewhat generic error message. The "not being translated" is because the crash might occur before the translations are loaded or even when trying to read a (corrupted) translation file.

Given that all reported crashes in savegame loading for the last few years were caused by either missing/wrongly loaded NewGRFs or patched versions of OpenTTD I'm not quite sure whether to invest time in making it give a shorter message when it crashed because of the patched version instead of missing NewGRFs.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791#comment7953

@DorpsGek
Copy link
Member Author

perk11 wrote:

Ok, but I think the last sentence still should be replaced by "If crash is caused by NewGRF, the missing NewGRFs are listed below" or something like that because now it makes misunderstand the crash reason.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791#comment7954

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r20818

This comment was imported from FlySpray: https://bugs.openttd.org/task/3791

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek