SmatZ wrote:

It seems there is only one problem. The easy way to crash the server was fixed by r19607.
Still, there is invalid read when a client is moved to spectators while connecting.

That is:
client wants to join passworded company
when he is typing the password, server uses "move client 255"
when client sends the packet with password, server does invalid read

attached patch fixes the invalid read, but when client connects, he joins wrong company (and is later kicked because there is a desync between server- and client-side 'client_playas')

Attachments

• fs3755.diff (1.12 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3755#comment7844

SmatZ wrote:

The problem is in network_client.cpp, DEF_CLIENT_RECEIVE_COMMAND(PACKET_SERVER_MOVE):

NetworkClientInfo *ci = NetworkFindClientInfoFromClientID(client_id);
returns NULL even for client_id == local client

This comment was imported from FlySpray: https://bugs.openttd.org/task/3755#comment7845

SmatZ wrote:

The harder way is fixed in r19613. Let's wait with closing this bug, so it stays privated.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3755#comment7847

SmatZ closed the ticket.

Reason for closing: Fixed

In r19607 and r19613. Needs backporting to 1.0.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3755