Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interesting handling of mixtures of rtl and ltr languages #3746

Closed
DorpsGek opened this issue Apr 8, 2010 · 5 comments
Closed

interesting handling of mixtures of rtl and ltr languages #3746

DorpsGek opened this issue Apr 8, 2010 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 8, 2010

planetmaker opened the ticket and wrote:

Clients can chose any language, thus independently an rtl or ltr language, thus nicknames are available in both rtl and ltr. The handling of rtl nicks in ltr languages is bad as it breaks the ltr strings. Probably the same applies in reverse. Attached the screenshot where I set an arabic nickname on one client and the console of a ltr (German) server where this client joins. Note the broken join message for the last client which is the arabic nickname.

Attachments

Reported version: 1.0.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3746
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2010

planetmaker wrote:

Just to clearify a bit what I tried to say: a rtl nickname (or sub string, could probably be town name and alike, too) should not change the word order of the ltr string it is inserted into. See also the translation bug report:
http://www.tt-forums.net/viewtopic.php?p=869808# p869808


This comment was imported from FlySpray: https://bugs.openttd.org/task/3746#comment7822

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2010

Rubidium wrote:

I've seen this happening, but I'm far from sure how to prevent such things from happening besides adding "don't break my ltr-ness" markers to the strings.

Maybe, just maybe we can use the ltr property to automagically add those markers. But it's not really that important as it's only the drawing that does this; the raw string still is "foo bar (RTLtext)".


This comment was imported from FlySpray: https://bugs.openttd.org/task/3746#comment7825

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r21004


This comment was imported from FlySpray: https://bugs.openttd.org/task/3746

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2010

Ammler wrote:

this fix breaks chat bridge with Autopilot, current workaround is to revert r21004, 6 & 7

Is it possible to use the first "control char" for rtl languages only or any other possibility?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3746#comment9022

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2010

Rubidium wrote:

The change is especially needed for left-to-right languages, like German/English, where Arabic/Hebrew client names mess up the printing of the text. So removing these characters will, in effect, reintroduce the bug. Going for another approach implies using one of the other text direction control characters which undoubtedly cause the same issue for you.

Even then, if you compile without ICU the character shouldn't be in the output at all.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3746#comment9023

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant