Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] _FILE_OFFSET_BITS undefined #3729

Closed
DorpsGek opened this issue Apr 2, 2010 · 2 comments
Closed

[OSX] _FILE_OFFSET_BITS undefined #3729

DorpsGek opened this issue Apr 2, 2010 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 2, 2010

planetmaker opened the ticket and wrote:

Recently trunk (e.g. r19536) versions start to give an error wrt zlib (several places, just quoted one here):
In file included from /opt/local/include/libpng12/png.h:497,
from /Users/ingo/ottd/fix_apple/src/crashlog.cpp:157:
/opt/local/include/zlib.h:1568:32: warning: "_FILE_OFFSET_BITS" is not defined

The same (now) happens with older revs (e.g. r19285), too, though; recently zlib got updates (zlib 1.2.4), too, and a couple of discussions is found on the net regarding this define:
http://www.mail-archive.com/freebsd-ports@freebsd.org/msg26336.html
This might suggest that it actually is rather a macports issue than an OpenTTD issue...

adding a # define _FILE_OFFSET_BITS 64 (or 32) in stdafx.h or osx_stdafx.h at an appropriate place silences this warning. But that's not a generally applicable solution, even if guarded by the # ifdef(APPLE)

Reported version: trunk
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/3729
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2010

Rubidium wrote:

Sounds very much like broken zlib headers; it's definitely not something that "we" should set.

Also 1.2.3 did already use _FILE_OFFSET_BITS, so it's very very likely a regression.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3729#comment7805

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 4, 2010

Rubidium closed the ticket.

Reason for closing: Won't fix

Harmless warning; solved by installing it into the "system includes" (or adding /opt/local/include to the system includes)


This comment was imported from FlySpray: https://bugs.openttd.org/task/3729

@DorpsGek DorpsGek closed this as completed Apr 4, 2010
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant