Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect handling on newgrf house action0's #3725

Closed
DorpsGek opened this issue Mar 27, 2010 · 4 comments
Closed

Incorrect handling on newgrf house action0's #3725

DorpsGek opened this issue Mar 27, 2010 · 4 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

csaboka opened the ticket and wrote:

As of r19519, OTTD's handling of newhouse action0's are violating the newhouses spec. OTTD rejects the GRF if it tries to modify a house whose property 8 isn't set (i.e. an undefined house). The spec in the TTDPatch wiki says:

"To start using a house ID, you must first define it by setting its property 08 (see below). If you try to modify a house ID whose property 08 isn't set, your request is ignored, but not reported as an error, either."

You can reproduce the problem by loading TTRS v3.02a and using parameters "1 5". It will report an error in sprite 4450, which tries to update every ID of the GRF and depends on the engine to ignore updates for houses that were not defined.

Please note that the same spec applies to industry tiles and industries as well. You may have the same issue in code handling those features.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3725
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2010

Yexo wrote:

Attached patch fixes the behavior for houses, industries and industry tiles. However I wasn't able to find anywhere in the spec that industries and industry tiles should behave in this way. Can you point me to the relevant page?

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3725#comment7801

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2010

csaboka wrote:

Hmm, you have a good point. This isn't documented properly - it is only hinted by the documentation with the sentences "Industry tiles work similarly to town buildings, [...]" and "Industries work similarly to town buildings as well, [...]". I will update the documentation tomorrow to make this explicit.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3725#comment7802

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2010

csaboka wrote:

I have just updated the TTDPatch wiki. Please let me know if you need any further clarification about the spec.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3725#comment7804

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2010

Yexo closed the ticket.

Reason for closing: Fixed

In r19547

This comment was imported from FlySpray: https://bugs.openttd.org/task/3725

@DorpsGek DorpsGek closed this as completed Apr 2, 2010
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek