Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on loading corrupted savegame #3714

Closed
DorpsGek opened this issue Mar 22, 2010 · 2 comments
Closed

Crash on loading corrupted savegame #3714

DorpsGek opened this issue Mar 22, 2010 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

king_zog opened the ticket and wrote:

Using Windows XP. Upon loading savegame 'NOT_REACHED triggered at line 719 of ..\src\saveload\vehicle_sl.cpp' error displayed.

Attachments

Reported version: 1.0.0-RC3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3714
@DorpsGek
Copy link
Member Author

Rubidium wrote:

OpenTTD crashes on that savegame because it is corrupt.

The decompressor sends invalid data before it figures out that it is decompressing something corrupt, so OpenTTD tries to interpret something incorrect and it bails out. If I let the decompressor read a little the decompressor tells that the file is corrupted.

This means that the corruption most likely has occured on the file itself and not by OpenTTD saving it.

I have to agree that OpenTTD should handle this case more gracefully, but that requires a relatively big rework of the code for loading savegames. As it only happens on already corrupted savegames it's not that severe to rush a fix.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3714#comment7779

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r20819


This comment was imported from FlySpray: https://bugs.openttd.org/task/3714

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant