Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sharing order list #3711

Closed
DorpsGek opened this issue Mar 20, 2010 · 3 comments
Closed

Stop sharing order list #3711

DorpsGek opened this issue Mar 20, 2010 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

sbr opened the ticket and wrote:

To stop sharing an order list while keeping the orders, it's needed to copy orders from another shared vehicle.

This patch use the 'Delete' button, refitted to 'Stop Sharing' when 'End Of Shared Orders' is selected:
- a click on it automatically find another shared vehicle and copy its orders.
- a ctrl+click on it deletes the order list as previously.

Please find an attached patch against r19477.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3711
@DorpsGek
Copy link
Member Author

DorpsGek commented May 1, 2010

Rubidium wrote:

You need to use stacked widgets/displayedplanes otherwise the widget sizing won't take the "stop sharing" string into account.

Also can't you just send a CO_COPY clone order with the right parameters instead of adding another case to clone order that just calls it again with CO_COPY and some derived parameters. That should make the patch a bit smaller (and faster).


This comment was imported from FlySpray: https://bugs.openttd.org/task/3711#comment7965

@DorpsGek
Copy link
Member Author

sbr wrote:

I've updated the patch taking in account your comments:
- The 'Delete' button is stacked with a new 'Stop sharing' button
- The logic is moved into a new method 'OrderClick_StopSharing(…)' in order_gui.cpp

Please find an updated patch against r19861.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3711#comment8061

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r21461


This comment was imported from FlySpray: https://bugs.openttd.org/task/3711

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant