Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Make main window decorations respect the LTR setting of the current language #3653

Closed
DorpsGek opened this issue Mar 1, 2010 · 5 comments
Closed

[Windows] Make main window decorations respect the LTR setting of the current language #3653

DorpsGek opened this issue Mar 1, 2010 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 1, 2010

admini opened the ticket and wrote:

I am using Hebrew versions of windows, from 3.1, 3.11, 95 and up. Microsoft from windows 98 repositioned "Start" menu in right, and the X [] _ on left when using translated applications.
In the last version, 1.0.0-RC1, the position of "X" on the titles changed to right.

look over the screenshot 1 (hebrew) and screenshot 2 (english). the "X" position on the english version is correct for hebrew users.

Attachments

Reported version: 1.0.0-RC1
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3653
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 1, 2010

Rubidium wrote:

The position of the "X" within OpenTTD's window is not horribly wrong. It might not be your choice to put it at that side, but it's not like OpenTTD is the only thing that does it this way. For example Mac OS X has the close button of windows on the opposite side in comparison to Windows.

The position of the "X" in English is exactly as it was in Transport Tycoon, which is the game we try to mimick. Completely overhauling the GUI means breaking that and thus effectively making OpenTTD not a clone of Transport Tycoon anymore. With RTL languages we "just" flip the complete GUI; not doing it for the title bar would only make that more complex.

The "X" of the OpenTTD (Windows) window being on the wrong side, that is something that concerns me more. However, I've got no clue about the cause of that or how to fix that.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3653#comment7641

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 1, 2010

admini wrote:

Thank you for your response.

If the problem is the flipping, may it can be disabled from openttd.conf file or something similar?

This comment was imported from FlySpray: https://bugs.openttd.org/task/3653#comment7643

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 1, 2010

Rubidium wrote:

Just recompile the language file saying it's a "ltr" language instead of "rtl". However, that undoes all the RTL support.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3653#comment7644

@DorpsGek
Copy link
Member Author

monoid wrote:

This patch makes the Win32 video driver's main window follow the right-to-left setting of the current game language.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3653#comment10178

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/3653

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek