Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIObject::DoCommand is horribly broken #3507

Closed
DorpsGek opened this issue Jan 9, 2010 · 3 comments
Closed

AIObject::DoCommand is horribly broken #3507

DorpsGek opened this issue Jan 9, 2010 · 3 comments
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 9, 2010

apunasi opened the ticket and wrote:

i was only the hoster, not a player.

Language: 0 [Any]
Map name: Random Map
Landscape: Temperate
Map size: 1024 x 1024
Server version 1.0.0-beta2
Server address(es): 88.152.125.29:3979
Dedicated server: No
Server password: No

no NewGRFs in use

i've no more informations for you. sorry.

Attachments

Reported version: 1.0.0-beta2
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3507
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2010

glx wrote:

kernel32.dll!75d7fbae()
[Les frames ci-dessous sont peut-être incorrects et/ou manquants, aucun symbole chargé pour kernel32.dll]
kernel32.dll!75d7fbae()
openttd.exe!CustomAbort(int signal=0x00000016) Ligne 413 C++
openttd.exe!raise(int signum=0x00000016) Ligne 590 + 0x4 octets C
openttd.exe!abort() Ligne 71 + 0x7 octets C
openttd.exe!error(const char * s=0x006ca470, ...) Ligne 127 C++
openttd.exe!NetworkSend_Command(unsigned int tile=0x00000000, unsigned int p1=0x000002d8, unsigned int p2=0x00000000, unsigned int cmd=0x00000000, void (bool, unsigned int, unsigned int, unsigned int)* callback=0x004ee273, const char * text=0x00000000) Ligne 61 C++
openttd.exe!AIObject::DoCommand(unsigned int tile=0x00000000, unsigned int p1=0x000002d8, unsigned int p2=0x00000000, unsigned int cmd=0x0b160222, const char * text=0x00000000, void (AIInstance ) callback=0x004f75a4) Ligne 239 C++
openttd.exe!AIVehicle::SendVehicleToDepot(unsigned short vehicle_id=0x0000) Ligne 168 C++
openttd.exe!SQConvert::HelperT<bool (__fastcall*)(unsigned short),0>::SQCall(void * instance=0x0012f9e8, bool (unsigned short)* func=0x00512bdf, SQVM * vm=0x020454b8) Ligne 218 C++
openttd.exe!SQConvert::DefSQStaticCallback<AIBaseStation,bool (__fastcall*)(unsigned short)>(SQVM * vm=0x00000000) Ligne 843 + 0xb octets C++
openttd.exe!SQVM::CallNative(SQNativeClosure * nclosure=0x0000000b, int nargs=0x00000001, int stackbase=0x00000047, SQObjectPtr & retval={...}, bool & suspend=false) Ligne 1171 C++
openttd.exe!SQVM::Execute(SQObjectPtr & closure={...}, int target=0x00000046, int nargs=0x00000005, int stackbase=0x00ffffff, SQObjectPtr & outres={...}, unsigned int raiseerror=0x00000001, SQVM::ExecutionType et=ET_CALL) Ligne 781 + 0x21 octets C++
openttd.exe!Squirrel::Resume(int suspend=0x00000000) Ligne 193 + 0x40 octets C++
openttd.exe!AIInstance::GameLoop() Ligne 382 + 0xe octets C++
openttd.exe!AI::GameLoop() Ligne 75 + 0xb octets C++
openttd.exe!StateGameLoop() Ligne 1204 C++


This comment was imported from FlySpray: https://bugs.openttd.org/task/3507#comment7317

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2010

Rubidium wrote:

The CMD_NO_TEST_IF_IN_NETWORK for sending a train to a depot isn't masked off in AICommand::DoCommand's call to Network_SendCommand.

However... none of the anti-desync stuff in DoCommandP seems to be done for AICommand::DoCommand. AICommand::DoCommand really must use DoCommandP and not implement that stuff itself.

Sadly enough this is probably going to be quite complex...


This comment was imported from FlySpray: https://bugs.openttd.org/task/3507#comment7319

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r18786


This comment was imported from FlySpray: https://bugs.openttd.org/task/3507

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant