Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32bpp FF works improperly #3504

Closed
DorpsGek opened this issue Jan 9, 2010 · 6 comments
Closed

32bpp FF works improperly #3504

DorpsGek opened this issue Jan 9, 2010 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 9, 2010

athanasios opened the ticket and wrote:

OS: MS Windows XP SP3 (tested)
Version: recent nightlies (tested)
-b: 32bpp-xxx

Fast Forward button works properly till 1st news message scrolls. Then it returns to normal speed (button pressed) with occasional speeding up (AI's off).

Seems that the FF button has an 'affair' ;-) with the Mouse pointer:

When Mouse pointer is within a certain area of the screen the game does not speed, when it is not it speeds.

Results vary with resolution (higher or lower than desktop one 1152x768), and fullscreen, windowed mode.

E.G:
*Game will FF only when cursor is near FF button or Button bar.

* Game will FF when cursor is everywhere except a specific range in x or y (often around middle of width (or FF range) or height).

NOTE: If you fail to reproduce this, please inform me to provide a video (I suspect it will be >8MiB limit).

Reported version: trunk
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/3504
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2010

Rubidium wrote:

Does this happen in older versions too? If not, since what version does this happen?

Fast forward "not working properly" is something I can't believe though. It goes as fast as it can, so if it doesn't go that fast it's just has a difficult time redrawing something. That's not the fault of the fast forward button.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504#comment7313

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2010

Rubidium wrote:

I can somewhat reproduce the issue, but only with 32bpp-anim, not with any of the others. I have to agree it's very odd.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504#comment7316

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2010

Rubidium wrote:

Some more info:
- it's where the network chat messages would be
- removing the palette animation (read full screen redraw) from CopyFromBuffer does the trick mostly, however that causes glitches
- some parts of the window are, at least with SDL and Allegro, drawn twice, but the impact from that should be relatively negligable w.r.t. the rest of the screen that gets dirtied.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504#comment7318

@DorpsGek
Copy link
Member Author

athanasios wrote:

You are right. It affects only 32bpp-anim.

Problem exists from last nightly-r18768 (XP, Linux) till:

. At least r16968 (XP, 32bit).
. At least r16754 (WinMe).

(These are the oldest binaries available on my PCs-"http://binaries.openttd.org/openttd/binaries/nightlies/trunk/" doesn't provide any older binaries", only source).

Problem DOES NOT exist on r16297 (Linux).

So bug must be inserted somewhere between r16297 and r16754.

I hope someone else has in between releases binaries to check so we do not need to compile...

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504#comment7320

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Looks like r16594 (fixing #2969) is the culprit

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504#comment7323

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r18791

This comment was imported from FlySpray: https://bugs.openttd.org/task/3504

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek