Zuu wrote:

I just want to tell that I have been able to suspend the AI just after the AILog.* call. Digging into the AI/squirrel stuff I was able to reduce the number of opcodes left with a big enough number to suspend the AI for the current tick. I guess this is what the word 'suspend' means in the OpenTTD AI code. (Suspending for the reminder of the current tick, but will run next tick again)

I've seen that in sqapi.cpp (and squirrel.h) there is 'sq_suspendvm' which could be used instead of 'sq_decreaseops' which I do use now. The problem is just that sq_suspendvm doesn't do anything. (I've checked the implementation and all it does is to throw some squirrel errors in case suspending isn't allowed)

Unless I'm able to suspend it in a cleaner way I might go for renaming the function-chain into DecreaseOps or something like that with a parameter for how many Ops to decrease with.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496#comment7484

Zuu wrote:

Oops, clicked on the wrong button. Here is the patch. I haven't added comments to the new Suspend functions etc. as it is so far quite experimental.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496#comment7485

Zuu wrote:

Man, I can't read today. (hit the Add comment button instead of Attach file button a second time... :-p )

Attachments

• ai_debug_break_on_string_v2_r18960.patch (8.82 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496#comment7486

Zuu wrote:

I have made these changes

* Make use of _settings_game.ai.ai_max_opcode_till_suspend instead of decreasing the number of opcodes left with 100 000.

* The widget table is now arranged so that the log panel and the new widgets share a vertical container. The scrollbar and the resize button is in another vertical container and these two are in a horizontal container. I made this change after looking at the town list to see how it was made there. Also this should work better if someone uses a large font as then the resize button will not get resized. I have also made a few tweaks so that it is more clear that the label is a label and not a button.

* When an AI is breaked the line that matched gets higlighted as shown in the attached screenshot.

* Added comments to the declarations of the new Suspend functions that has been introduced.

* Fixed some coding style issues

The big comment is still there regarding the constant checking for if the game has been unpaused. Either that constant checking has to be acceped or I need to hook in somewhere in the game loop where there is code that is ran when the game is unpaused.

Attachments

• Inget namn, 2 jan 1957.png (17.06 KiB)
• ai_debug_break_on_string_v3_r18960.patch (10.28 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496#comment7510

Zuu wrote:

Changes:

* Highlight with black background and invert black text to white. (but red and yellow text is drawn unchanged on black background)
-- After having looked into the colour palette table in the source code I thought index 0 == black but I haven't been able to validate that on the DOS palette.

* Added Match Case button
* Added button at the bottom left to toggle the break checking on/off if you temporarily want to disable the checking without erasing what you have typed.

* The state of the two new buttons as well as the break string is stored in class static variables so that the states can be restored if the window is closed and opened again.

* Renamed some of the introduced variables to have more consistent naming of the new feature.

* Updated to last SVN version. (some time ago)

----

I think I have addressed most issues that I mentioned in my first post. I haven't added a clear button, but that would use up some more horizontal space and leave little space for typing unless one first resize the AI Debug window.

Comments on the patch are welcome.

Attachments

• BreakOnString_v4.png (18.03 KiB)
• ai_debug_break_on_string_v4_r19049.patch (13.37 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496#comment7544

Yexo closed the ticket.

Reason for closing: Implemented

In r19544

This comment was imported from FlySpray: https://bugs.openttd.org/task/3496