Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train depots & forbid 90 degree turns: Don't make unusable connections #3479

Closed
DorpsGek opened this issue Jan 4, 2010 · 3 comments
Closed

Train depots & forbid 90 degree turns: Don't make unusable connections #3479

DorpsGek opened this issue Jan 4, 2010 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 4, 2010

Zuu opened the ticket and wrote:

It would probably help some new players if the code that automatically connect depots when you build them were aware of the forbid 90 degree turn settings.

This requires knowledge of more than just the adjacent tile, so it is a bit more complex.

The attached screenshot shows how I think the game should react on different track configurations, when you build a depot and have forbid 90 degree turns enabled. It is not 100% good, but it is at least somewhat likely that new players will get aware of the forbid 90-degree setting, when they play at servers with it enabled.

Attachments

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3479
@DorpsGek
Copy link
Member Author

Rubidium wrote:

The attached patch more of less implements this, but fails in the right most two cases. Bascially because it only looks at the local tile, not at the neighbouring tiles.
However, doing that means that the behaviour would change in the case you have a straight piece of track with a tile missing and you build a depot just next to the missing rail tile. With the changed behaviour it would connect those. Though better it's quite a bit more complex.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3479#comment7357

@DorpsGek
Copy link
Member Author

Zuu wrote:

Indeed it is quite a bit more complex to address the cases when you need to analyze more than one tile. It will take quite some time to get a good pattern of checks to accomplish that. That said just doing what you have done will hopefully make the new players to think. If they add the track and the train get stuck they are themself to blame. Hopefully most of them realize what to do and only very few of them complain about the train being stuck.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3479#comment7359

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

I discussed this with Zuu, and he's happy with it being closed as part of Flyspray clean up.

It's a good example of simple-looking settings spawning extra effort to make them work right :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3479

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek