Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomization should happen before CBs #3477

Closed
DorpsGek opened this issue Jan 4, 2010 · 11 comments
Closed

Randomization should happen before CBs #3477

DorpsGek opened this issue Jan 4, 2010 · 11 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 4, 2010

George opened the ticket and wrote:

R18545

// assemble all varianths
2595 * 17 02 07 CF 00 8C 05 00 00 5A 12 00 00 00 00 10 10 40
2596 * 17 02 07 CF 85 0C 00 FF FF 01 00 80 17 00 17 00 CF 00
2597 * 39 02 07 FF 80 00 00 10 C0 00 C1 00 C2 00 C3 00 C4 00 C0 00 C1 00 C2 00 C3 00 C4 00 C0 00 C1 00 C2 00 C3 00 C4 00 CF 00
2598 * 7 03 07 01 F7 00 FF 00

This code should disable variant CF, because it returns 00 80 in CB 17.
But as you can see, variant CF is represented on the map. It makes me think, that OTTD places the house on the map with CB 17, and then randomizes it.
Would it be possible to make randomization first?

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3477
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2010

George wrote:

[13:30:36] <@peter1138> George, the house doesn't exist during CB 17, so there will be no random data
[13:30:59] Is it possible to change it?
[13:32:17] <@peter1138> hmm, they could be placed in var10
[13:33:21] You mean place it in var 10 and then apply to the house when it is build? IMHO, that's fine
[13:33:41] <@peter1138> yes


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7236

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2010

peter1138 wrote:

The attached patch will put the random data in var10 for CB17.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7238

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2010

George wrote:

Here is test GRF. Banks should use var 10 as random byte

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7241

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2010

peter1138 wrote:

Not very useful as a test case -- there's way too much other stuff going on...


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7252

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2010

George wrote:

Do you mean to make a small GRF with only banks? No problem, here it is

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7254

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2010

George wrote:

If you need any special GRF - let me know


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7255

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2010

peter1138 wrote:

Well, actually I wanted to know how TTDP dealt with the random bits... to see if it was something we needed to fix, instead of adding new stuff to the spec.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7266

@DorpsGek
Copy link
Member Author

George wrote:

Please, let me know what stops this small patch to go to trunk? It is required to make ECS houses become available for testing. Please include it in trunk if possible.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7400

@DorpsGek
Copy link
Member Author

George wrote:

Please, let me know how it goes.
Are there any problems that prevents the diff to go to trunk?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7481

@DorpsGek
Copy link
Member Author

frosch wrote:

Discussion has been moved to http://www.tt-forums.net/viewtopic.php?f=68&t=47328 .


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477#comment7609

@DorpsGek
Copy link
Member Author

DorpsGek commented May 1, 2010

frosch closed the ticket.

Reason for closing: Implemented

in r19744


This comment was imported from FlySpray: https://bugs.openttd.org/task/3477

@DorpsGek DorpsGek closed this as completed May 1, 2010
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant