Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houses: allow sloped land under houses #3466

Closed
DorpsGek opened this issue Jan 1, 2010 · 16 comments
Closed

Houses: allow sloped land under houses #3466

DorpsGek opened this issue Jan 1, 2010 · 16 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 1, 2010

George opened the ticket and wrote:

r18545

Special house "Praha hotel" intends to be build on the sloped land, where the NE tile is sloped, while the SW tile is flat.
I use the following code
// FF specifies the SW tile, F0 the NE tile
357 * 15 02 07 FF 81 62 00 00 1F 01 F0 00 00 00 00 80
358 * 23 02 07 F0 81 62 00 00 1F 03
F0 00 04 04
F0 00 0C 0C
F0 00 00 00
00 80

For CB 17, but OTTD puts a house on the tile that does not fit this rule. At the example, the SW tile is located on the 0E slope
Is it a bug in my code or in OTTD?

Attachments

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/3466
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 1, 2010

George wrote:

BTW, if I do not allow NE tile to be build on 00 slope, it does not appear at all


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7192

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2010

Yexo wrote:

From http://wiki.ttdpatch.net/tiki-index.php?page=Callbacks# House_construction_check_17_
"For multi-tile buildings, this callback is always called for the north tile type .... in OTTD r13489, the callback is now called for the final position of the north tile."

The callback is only called once, and only for the north tile. Your check for the southwest tile is never executed.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7211

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

Would it be hard to call it for every tile?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7222

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

frosch wrote:

The callback is also supposed to check lots of other stuff (like population etc.) which you only want to call once.
Isn't checking the adjacent tiles in the north-tile callback enough?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7227

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

Well, I changed the code for hotel praha as you suggest, and now I get no instance on the map. Why?
// Slope check
358 * 15 02 07 F0 81 62 10 00 1F 01 F0 00 00 00 00 80
359 * 19 02 07 F0 81 62 00 00 1F 02
F0 00 04 04
F0 00 0C 0C
00 80

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7228

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

Also, when I allow northern tile to be flat, I get the house located on land with non-flat southern tile
// Slope check
359 * 15 02 07 F0 81 62 10 00 1F 01 F0 00 00 00 00 80
360 * 23 02 07 F0 81 62 00 00 1F 03
F0 00 04 04
F0 00 0C 0C
F0 00 00 00
00 80

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7229

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

Sorry, looks my fault here, should be 01, not 10


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7230

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

Changed 10 to 01, but it does not apppear

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7231

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2010

George wrote:

and appears if flat northern tile is allowed
// Slope check
359 * 15 02 07 F0 81 62 01 00 1F 01 F0 00 00 00 00 80
360 * 23 02 07 F0 81 62 00 00 1F 03
F0 00 04 04
F0 00 0C 0C
F0 00 00 00
00 80

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7232

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2010

frosch wrote:

Ok, the grf defines the following house:
House 0xA1 in NE, house 0xA2 in SW.
It requires the SW tile to be flat, and the NE tile to be sloped with either East corner raised or North&East corner raised.
So far so good.

The problem is:
Callback 17 can only restrict the possible house locations and not allow "more".
A normal 2x1 house is build on two adjacent tiles which get a leveled platform. For that OTTD checks that the platforms have equal heights. But with above slope combination the tiles do not have equal heights.

So maybe we need a new flag in property 19 to disable any default slope checks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7249

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 4, 2010

George wrote:

Yes


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7250

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2010

George wrote:

BTW, what does the status "Waiting on reporter" mean?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment7262

@DorpsGek
Copy link
Member Author

Rubidium wrote:

It means that at some moment "we" needed a reply from you.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment8381

@DorpsGek
Copy link
Member Author

George wrote:

And why didn't contacted me then? ;)


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment8382

@DorpsGek
Copy link
Member Author

Rubidium wrote:

It was changed to that just after one of the developers asked you a question. If you email address was correct at that point you would have gotten an email with the question (which is now over half a year old though). Same way that you should receive an email about this comment.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3466#comment8385

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 7, 2018
@andythenorth
Copy link
Contributor

8 years old. Not currently a goal. We'll pass on this thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants