Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash with malformed(?) warning string in NewGRF #3452

Closed
DorpsGek opened this issue Dec 30, 2009 · 2 comments
Closed

Crash with malformed(?) warning string in NewGRF #3452

DorpsGek opened this issue Dec 30, 2009 · 2 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

Toying around with the snow line height, I triggered a crash of OpenTTD with my current testing version of my snow line height newgrf. Find crash.log and newgrf attached.

I'm aware that the newgrf isn't yet proper, but trying to look at the notice I added to test my parameter calculations it shouldn't crash either IMO.

Tested in r18664

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3452
@DorpsGek
Copy link
Member Author

planetmaker wrote:

actually: sprite # 23 is definitely malformed. 2 parameters are expected, only one is given, the 2nd and the termination byte are missing.

So... not sure it's worth a fix / a hardening.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3452#comment7170

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r18671

This comment was imported from FlySpray: https://bugs.openttd.org/task/3452

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek