Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBS paths not linked to trains on bridges. #3345

Closed
DorpsGek opened this issue Dec 3, 2009 · 1 comment
Closed

PBS paths not linked to trains on bridges. #3345

DorpsGek opened this issue Dec 3, 2009 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 3, 2009

Hirundo opened the ticket and wrote:

Tested in r18387.

See the attached savegame. Demolish the tile between the arrows to see the bug in action.

When a part of a reserved path is demolished or otherwise changed, the entire path of the vehicle is unreserved. To do this GetTrainForReservation is used. This function fails to find the correct train when the train is on a bridge. This causes leftover reservations that don't belong to any vehicle. If reserved paths aren't shown, this could be very confusing to the user.

Attached is a hg diff that fixes the problem for me. However, I don't know the code intimately enough to make sure that there aren't any side effects.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3345
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

frosch closed the ticket.

Reason for closing: Fixed

in r18392. Thanks for patch :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/3345

@DorpsGek DorpsGek closed this as completed Dec 3, 2009
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant