Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all cargoes that have a town effect instead of one per effect #3341

Closed
DorpsGek opened this issue Dec 2, 2009 · 10 comments
Closed

Show all cargoes that have a town effect instead of one per effect #3341

DorpsGek opened this issue Dec 2, 2009 · 10 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 2, 2009

George opened the ticket and wrote:

R18359

Town requirements are not always correct

  1. town requires food even when snownline is above town in summer. As it was described for TTDPatch, the town requires food when town sign is above snow line and does not require when below.
  2. town requires steel instead of water when water is defined on the other slot and steel is defined on water slot
    // - Water (ID 1B, Bit 1B)
    430 * 57 00 0B 13 01 1B
    08 \b27
    09 \wx21
    0A \wx41
    0B \wx61
    0C \wx81
    0D \wxA1
    0E \wx10D6
    0F 10
    10 14
    11 50
    12 \dx1238
    13 92
    14 92
    15 01
    16 \wx40
    17 "WATR"
    18 09
    19 \wx100
    1A 00

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3341
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 2, 2009

George wrote:

New ECS Town vector

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment6999

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

frosch wrote:

Wrt. 2): I cannot reproduce the problem when only loading that TownVector. Which vectors do I also have to load?
However, this is how it should behave: The town should sum up any delivered cargo with the water-/food town effect (cargo property 18). In the town window the first cargoslots with those towneffects are shown. So can you please check property 18 of the steel definiton.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7007

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

frosch wrote:

Wrt 1): Ok, somewhat confirmed. Food is indeed only required in winter. Just the town view shows the "requirement" the whole year if there is at least one winter day.
I cannot remember my exact reasoning back then. But one issue might have been, that the food/water delivery of the previous month decides about growth. I.e. you would need to display "food required" if the next month contains "some winter", which might be quite confusing from a user point of view.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7008

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

George wrote:

  1. Machinery vector, of cause

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7010

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

George wrote:

// - Steel (ID 09, Bit 09)
438 * 50 00 0B 10 01 09
08 \b9
09 \wx18
0A \wx38
0B \wx58
0C \wx78
0D \wx98
0E \wx10D2
0F 10
10 07
11 FF
12 \dx1638
13 B7
14 B7
15 01
16 \wx20
17 "STEL"


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7011

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

frosch wrote:

You have to set cargo property 18 to FF for slot 09, if it is no longer "water". Add it to Machinery Vector sprite 550, and likely also to Town Vector sprite 596.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7012

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

George wrote:

adding these props to steel fixes problem 2)
18 ff
19 \wx0000
1A 00
So, the problem was that in tropics these props were not redefined


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7013

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

George wrote:

  1. May be to change the text to "Food required in winter"? Or something like that?
    Imho, the best would be to display the text when it is required, even if it is next month. The player can considerate it as preparation (collecting food before winter).

This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7014

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2009

George wrote:

  1. what should be displayed if two cargoes are marked as water? Shouldn't OTTD display them both, separated with comma?
    In the case of wrong steel definition, it would be "steel, water required"

This comment was imported from FlySpray: https://bugs.openttd.org/task/3341#comment7015

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: more than 5 years old, and not obvious what should be done with this next, so closing. If this offends, discuss with andythenorth in irc. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3341

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewCargos labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant