Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewport zoom level is not reset when quitting a game after having saved #3333

Closed
DorpsGek opened this issue Nov 28, 2009 · 9 comments
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

fonsinchen opened the ticket and wrote:

The zoom level and possible other game parameters are not reset when reloading the title game after abandoning a game that has been saved before. To reproduce load the attached save (or probably any other), save the game again, zoom out, quit the game. The title game is at the same zoom level as the game you have just aborted.

This may be related to the following report: http://www.tt-forums.net/viewtopic.php?f=33&p=834082# p834082
In this game the newgrf configuration from the previous game is carried over to the title game where conflicting settings cause a crash.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3333
@DorpsGek
Copy link
Member Author

Rubidium wrote:

I can't reproduce this. Either by going through the main menu and loading that savegame or directly loading it with -g.

It is:
- load game
- save game
- zoom out (either with mouse scroll or the buttons in the toolbar)
- abandon game
- see a zoomed out intro game

Right? Anyhow, as I said it doesn't happen for me with r18324.

Besides the NewGRF config it likely the configuration for new games. It 'just' isn't loaded in the intro game. To 'prove' this point: create a NewGRF configuration in the main menu, quit the game, start the game, open the console, type gamelog and see that it added NewGRFs even though they are not loaded.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6988

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

Actually the order is:

- load game
- zoom out (with key '-' here, but it probably doesn't matter)
- save game
- abandon game
- see zoomed out intro game

Sorry for the confusion. I just checked with r18324, too, and it's 100% reproducible here.

The problem in that forum post was that it doesn't only add the grfs but also partly loads them, so that the food (I think) train passing over the bridge in the title game gets corrupted. That's what the message in the screenshot says. However, I know that's not trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6989

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Does it happen when you disable threaded_saves ? ("set threaded_saves 0" in console)


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6990

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

Yes, it's the same with threaded_saves off.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6991

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Do you use clean trunk?
It seems VIEW chunk is for some reason not loaded. Can you check it is loaded? (SaveLoad_VIEW() is called when loading intro game?)
Does it happen when you leave the game using "part" console command?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6992

@DorpsGek
Copy link
Member Author

Rubidium wrote:

What kind of local modifications do you have in the binary? I can't map the revision to either something in the cargodist repository or in the official trunk repository.
And with r18324 do you mean: r18324 without modification or r18324 with modifications?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6994

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

The only changes I made was adding my patch building system to the master branch. It doesn't change any openttd code. However, for the sake of the argument here I provide a savegame from a fresh SVN checkout of r18324 that does the exact same thing. SaveLoad_VIEW is called once when saving the game and once when aborting it. The effect also occurs when using "part" instead of the menu.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6996

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

The effect could be related to the CPU's byte order. It occurs on my powerpc laptop, but is curiously absent on my x86_64 desktop. Both are using debian lenny with the same libraries and the same compiler: g++ (Debian 4.3.2-1.1) 4.3.2


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333#comment6997

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

in r18351


This comment was imported from FlySpray: https://bugs.openttd.org/task/3333

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant