Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle Deletion Crash [News Window Related?] #332

Closed
DorpsGek opened this issue Sep 5, 2006 · 3 comments
Closed

Vehicle Deletion Crash [News Window Related?] #332

DorpsGek opened this issue Sep 5, 2006 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 5, 2006

PandaMojo opened the ticket and wrote:

Bug occurs in R6392. It's somewhat difficult to reproduce. I've attached the savegame being affected by it.

The steps I've followed to cause the crash (does not always reproduce the behavior):

  1. Select various buses at Cunnigton that are no longer needed (their routes were shortened, and now queue large amounts)
  2. U-Turn them then "Send to Depot" to get them out of their queue. I keep their windows open.
  3. Once they start to arrive at the depots, I start deleting them. In my experience there's about a 20% chance of reproducing it per attempt. I usually do this to 2-4 buses at a time, deleting as they arrive.
  4. Crash occurs during one of the buses deletion.

I have not reproduced the bug in debug mode or with a newer/smaller savegame, nor narrowed down the exact cause. I have reproduced it in release mode with Visual Studio 2005's debugger attached.

Crash details: Occurs around DrawWindowViewport due to the window w (which is within _windows and _last_window, so presumibly valid) having a null viewport (causing ViewportDraw to crash presumably, although it is not shown in the release mode stack trace). Of note is w->wndproc == NewsWindowProc, so I'm guessing DestroyVehicleNews (or was that Delete?) as called by DeleteVehicle (or Destroy, if the other one was Delete) isn't working properly, or something is messed up with the FIFO news queue. Either way I'm at a loss.

Reported version: trunk
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/332
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 8, 2006

PandaMojo wrote:

I think I just uncovered this bug in another manner as well - I had no bugger attached so I was unable to interpret the stack at the time but it occured in a similar manner - A coal train was created, and after the first trial run I noticed it needed a second engine. So I sent it to depot, created the second train, dragged it over (thus removing "Train 2" since it's only engine was now in "Train 1")... boom, crash. Found where the crash savegames are put - unfortunately the game runs fine right afterwards. Odd note - said train immediately left the depot in said savegame, whereas it had been ordered to stay in the depot.

The game had just recently started, which gives me more hope of being able to reproduce it and debug it, since I can run smaller games decently in debug mode.

This comment was imported from FlySpray: https://bugs.openttd.org/task/332#comment523

@DorpsGek
Copy link
Member Author

Darkvater wrote:

I had a crash with it as well, about 'invalid string'. It was even without doing any vehicle deletions. I think it might be related to the borked windowing system. I will try a fix for that and see if these things still happen.

The othe thing might of course be the news-system, have not looked into it yet, what it would do with invalid, or out-of-date news-items.

This comment was imported from FlySpray: https://bugs.openttd.org/task/332#comment548

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 5, 2006

Darkvater closed the ticket.

Reason for closing: Fixed

Fixed in SVN

This comment was imported from FlySpray: https://bugs.openttd.org/task/332

@DorpsGek DorpsGek closed this as completed Dec 5, 2006
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek