Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variable that points to OpenTTD Useful for Visual Studio #3269

Closed
DorpsGek opened this issue Oct 16, 2009 · 3 comments
Closed

Environment Variable that points to OpenTTD Useful for Visual Studio #3269

DorpsGek opened this issue Oct 16, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

boekabart opened the ticket and wrote:

In Visual Studio, you 'need' the ottd useful set in order to compile. Until now, you have to make sure the include- and library folders are in your global include directories OR you have to manually add them to the vcproj file for every working copy (annoying when making patches, always need to remove those manually).

Suggested solution:
"* Add $(OTTD_USEFUL)win32\include (and the likes for win64/shared) to AdditionalIncludeDirectories, and AdditionalLibraryDirectories="$(OTTD_USEFUL)win32\libary" (and the likes for win64) to each of the project configurations.
* OTTD_USEFUL may be defined, absolute or relative path, including trailing backslash"

Rationale:
* Current deployments don't break. If OTTD_USEFUL is empty, it just won't find the (relative!) folders like win32\include, win64\library, and they will be conveniently ignored.
* Users that have multiple different versions of libpng or others on their system, can have each project reference his own correct one. No global include directories.
* If there is a global include, the one listed in the project goes first. So, global can list to another one than the one openttd uses.
* Users can have multiple working copies of OTTD src, with 1 useful for all (absolute path) or 1 useful per WC if they want (relative path)
* No more local changes to project files necessary.

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/3269
@DorpsGek
Copy link
Member Author

boekabart wrote:

Hereby the suggested patch. Patches only the .in files, not the vcproj's directly.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3269#comment6830

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Adding this adds several warnings about undefined variables if the environment variable OTTD_USEFUL isn't set.

Sadly enough these warnings cannot be ignored and with the 'average' knowledge of people filing 'bug reports' about something not compiling they see those warnings as the cause of the problem.

On the other hand the idea is good; maybe do this closer (just before) to a major release so the manuals can be changed in a way that works for both 'trunk' and the 'stable' binaries. Problem with that is that I fear that the way to set those global variables looks different on each version of Windows (can also be my vision because of not using Windows a lot). Especially because of the 'noobs' would fail to do it if the image doesn't match 100%.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3269#comment6867

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/3269

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant