Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewGRF window glitch #3206

Closed
DorpsGek opened this issue Sep 17, 2009 · 4 comments
Closed

Add NewGRF window glitch #3206

DorpsGek opened this issue Sep 17, 2009 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

SmatZ opened the ticket and wrote:

r17558

Intro screen, click NewGRF Config, click Add, click again NewGRF Config (without closing it). Reopen the window several times - Add NewGRF window is glitchy.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3206
@DorpsGek
Copy link
Member Author

SmatZ wrote:

Actually, the problem seems to be related to closing the NewGRF Settings window. Probably it would be best to close the NewGRF Add window too (unless someone wants to inspect this problem deeper).


This comment was imported from FlySpray: https://bugs.openttd.org/task/3206#comment6663

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I would've reckoned that the add window had the NewGRF settings window as parent (and thus was automagically removed).


This comment was imported from FlySpray: https://bugs.openttd.org/task/3206#comment6665

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Hmm, even worse; adding NewGRFs after you've closed the window doesn't work reliably. The behaviour differs between saying you're adding a duplicate NewGRF (to an empty list), adding the NewGRF and segfaulting. When I tried it in 0.7 it segfaulted too.

So... closed the window must be.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3206#comment6666

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

the crash in r17558 by always closing the add window if the settings window gets closed; as such the glitch cannot occur.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3206

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant