Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewGRF presets from openttd.cfg are not validated #3197

Closed
DorpsGek opened this issue Sep 12, 2009 · 1 comment
Closed

NewGRF presets from openttd.cfg are not validated #3197

DorpsGek opened this issue Sep 12, 2009 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

frosch opened the ticket and wrote:

Applies to both 0.7.2 and trunk.

By editing openttd.cfg you can create presets which contain the same newgrf resp. newgrfs with same grfid multiple times.

When starting a new game with such presets the list is filtered and duplicate files and duplicate grfids are removed. However, when applying grfs ingame the list is not filtered and all grfs are activated.

When one instance of the grf causes the grfid to be deactivated (in the test scenario due to exceeding maximum number of grfs) OTTD crashes when loading subsequent newgrfs. Either by assert "src/newgrf.cpp:6222: void LoadNewGRF(uint, uint): Assertion 'GetFileByGRFID(c->grfid) == _cur_grffile' failed." or if disabled by usererror
"Error: File '<some subsequent newgrf' lost in cache."

Reported version: 0.7.2
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3197
@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r17510


This comment was imported from FlySpray: https://bugs.openttd.org/task/3197

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant