Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose town name before creation #3185

Closed
DorpsGek opened this issue Sep 8, 2009 · 5 comments
Closed

Choose town name before creation #3185

DorpsGek opened this issue Sep 8, 2009 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 8, 2009

Terkhen opened the ticket and wrote:

This patch implements one of SmatZ's ideas for the found a town feature. This feature allows to decide the name of a town before placing it, either by selecting random names or by writing it directly. It has been developed with the Found a town patch in mind, but it is useful for the scenario editor too. Check the attached screenshot to see the finished GUI.

This patch needs to be applied after the "Support for nested QueryStringBaseWindow" patch, as it makes FoundTownWindow a working nested QueryStringBaseWindow. You can find it here: http://bugs.openttd.org/task/3184

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3185
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2009

Terkhen wrote:

New version that (should) correct a segmentation fault in non-windows systems. I have checked that the patch works correctly when there is no town names remaining using the attached GRF file (it only has four possible town names).

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3185#comment6612

@DorpsGek
Copy link
Member Author

Terkhen wrote:

I have corrected some white spaces in empty lines, cleaned the code a bit and corrected a few coding style issues.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3185#comment6631

@DorpsGek
Copy link
Member Author

Petert wrote:

I like it! I hope it's in trunk soon.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3185#comment6649

@DorpsGek
Copy link
Member Author

Terkhen wrote:

New version, updated for recent changes in trunk. The patch has been compiled and tested in linux. The "Support for nested QueryStringBaseWindow" patch is now in trunk, so now you can try this patch without anything else.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3185#comment6650

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Implemented

r17612

This comment was imported from FlySpray: https://bugs.openttd.org/task/3185

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek