Alberth wrote:

Nice patch, comment attached.

Attachments

• nested_querystring_r17477_edited.diff (6.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3184#comment6627

Terkhen wrote:

Thanks, here is a new version.

# # # No white space at the end of the line!

^ They have been corrected.

# # # For the quest to eliminate magic constant values from the window code, please replace them with the appropriate WD_* value from window_gui.h (WidgetDrawDistances enum).

^ I'm not sure that I got the vertical parts right (maybe I am mistaking WD_FRAMERECT_TOP and WD_FRAMERECT_BOTTOM). Using (WD_FRAMERECT_TOP + WD_FRAMERECT_BOTTOM) with top and bottom I was able to align the text into the edit box better (see attached screenshots), but since I don't know if the current alignment is motived by fonts other than the standard, I left it as it was.

# # # The if() throws compiler warnings all over the place (ie for many files):

^ I can't test compilation with other platforms right now, at MSVC it doesn't give any warnings. It should be corrected now anyways.

NULL pointers in the nested_array:
Since the prgrammer has control when this code is used, it may not be bad choice to let the program crash

^ I left them uncorrected, but I added asserts to inform about the problem.

Attachments

• nested_querystring_r17491.diff (4.98 KiB)
• trunk.png (15.01 KiB)
• nested_querystring.png (14.93 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3184#comment6629

Alberth closed the ticket.

Reason for closing: Implemented

in r17502

This comment was imported from FlySpray: https://bugs.openttd.org/task/3184