Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved version detection for MacOS-X #3156

Closed
DorpsGek opened this issue Aug 29, 2009 · 5 comments
Closed

Improved version detection for MacOS-X #3156

DorpsGek opened this issue Aug 29, 2009 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

The attached patch fixes not-always-correct version detection for MacOS-X. Code adopted for OpenTTD from http://www.cocoadev.com/index.pl?DeterminingOSVersion

Patch for mercurial, trunk r17291, tested for MacOS 10.4.11.

It also addresses some minor coding style issues in the vicinity of this code, namely declaring variables only immediately prior to their first use and the fact that the used newgrfs are not actually checked, thus "unknown" is returned instead of "none".

Attachments

Reported version: trunk
Operating system: Mac OS X

This issue was imported from FlySpray: https://bugs.openttd.org/task/3156
@DorpsGek
Copy link
Member Author

planetmaker wrote:

Btw, that fixes r8605 :-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3156#comment6555

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Updated wrt coding style upon review by SmatZ

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3156#comment6556

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Version 2 of the patch which does a bit more thorough cleanup, unification and simplification in the version determination.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/3156#comment6558

@DorpsGek
Copy link
Member Author

planetmaker wrote:

small coding style update attached to FS 2782. IMO this entry can be closed as it's better solved in the context of FS2782.

http://bugs.openttd.org/task/2782/getfile/4667/version_detection.diff

This comment was imported from FlySpray: https://bugs.openttd.org/task/3156#comment6563

@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Requested by user

as requested

This comment was imported from FlySpray: https://bugs.openttd.org/task/3156

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek