Nickman wrote:

Updated my patch to new revision (17269) and removed some more magic numbers to make the patch more complete.

Attachments

• signList-NewWidget_17269.patch (5.79 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6522

SmatZ wrote:

+ //Create initial list
doesn't comply with coding style. Use /* */ style comments when there is no code on the line

+ case SLW_LIST: { //The list has to be drawn
is just weird (missing space after //, NEVER use tabs anywhere else than on the beginning of the line)

+ BuildSignsList();
should be this->BuildSignsList(); if possible - trunk doesn't use correct coding style here...

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6523

Nickman wrote:

Modified patch to conform to the coding style and noted the style for future additions.
Also updated to revision 17273

No further changes made

Attachments

• signList-NewWidget_17273.patch (5.82 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6525

SmatZ wrote:

+ if (data == 0) { //New or deleted sign
+ //Rebuild the list
+ } else { //Change sign contents
+ this->SortSignsList(); //Try to sort the list after each change

Thanks for update, these still have improproper coding style (there should be space after // ). Maybe there are more places like these, I had just a quick look...

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6529

Nickman wrote:

Updated the comment format and upped to revision 17274.

Attachments

• signList-NewWidget_17274.patch (5.83 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6530

Alberth wrote:

My comment as patch to the patched file.

Attachments

• comment_signlist_17274.patch (3.36 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6540

Nickman wrote:

Long time since I updated (holiday) but here is an altered version of the patch, updated to revision 17405 along with the new methods for changing some variables introduced in one of the new revisions.

Attachments

• signList-NewWidget_17405.patch (5.81 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144#comment6588

Alberth closed the ticket.

Reason for closing: Implemented

in r17418

This comment was imported from FlySpray: https://bugs.openttd.org/task/3144