OpenTTD

Tasklist

FS#3139 - debug messages when wrong newgrf found upon load of savegame

Attached to Project: OpenTTD
Opened by Ingo von Borstel (planetmaker) - Saturday, 22 August 2009, 05:39 GMT
Last edited by Remko Bijker (Rubidium) - Saturday, 22 August 2009, 20:20 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When loading a game with newgrfs where it is fatal that one doesn't have some (or wrong ones) of them, a debug message is generated like

NewGRF 4A430002 (ottdc_grfpack/z_obsolete/indstatr/indstatrw_010.grf) not found; checksum EDB2D36A0D90AE324B869C86183890F3. Tried another NewGRF with same GRF ID

The wording of this messages is IMO quite misleading. The file mentioned there (and the checksum) are those which are actually found. But they're not the one needed by the savegame. I tried with different versions of the ISR (a very bad newgrf with its incompatible versions, but same grfID), and it was always mentioned the file which was actually accessible by OpenTTD, but not the required MD5; that makes searching for the correct version difficult.

So... maybe this could or should also be a feature request to show the expected MD5 of the missing newgrf.

Tested OpenTTD Version: r17246
This task depends upon

Closed by  Remko Bijker (Rubidium)
Saturday, 22 August 2009, 20:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r17267
Comment by Ingo von Borstel (planetmaker) - Saturday, 22 August 2009, 05:45 GMT
What I actually would like to see is something like

NewGRF 4A430002: Found file/with/path.grf with checksum EDB2D36A0D90AE324B869C86183890F3 while searching for checksum <whatever> with same GRFID
Comment by Remko Bijker (Rubidium) - Saturday, 22 August 2009, 07:17 GMT
The MD5 checksum that *IS* shown is the MD5 checksum of the file that is missing. Also the filename shown is the filename as stored in the savegame, not the filename of the newly loaded NewGRF.

I made a savegame with v0.6 of Japanese stations.

Then I removed that NewGRF and loaded the savegame:
dbg: [grf] NewGRF 45530400 (japanese_stations.0.6/jpstatsw.grf) not found; checksum 0CB1191FF67BA594F64B2934CFAEDF58

And later I downloaded version 2 and loaded the savegame:
dbg: [grf] NewGRF 45530400 (japanese_stations.0.6/jpstatsw.grf) not found; checksum 0CB1191FF67BA594F64B2934CFAEDF58. Compatibility mode on
dbg: [grf] Loading GRF 45530400 from japanese_stations.2.0/jpstationsw.grf

Loading...