Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug messages when wrong newgrf found upon load of savegame #3139

Closed
DorpsGek opened this issue Aug 22, 2009 · 3 comments
Closed

debug messages when wrong newgrf found upon load of savegame #3139

DorpsGek opened this issue Aug 22, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

When loading a game with newgrfs where it is fatal that one doesn't have some (or wrong ones) of them, a debug message is generated like

NewGRF 4A430002 (ottdc_grfpack/z_obsolete/indstatr/indstatrw_010.grf) not found; checksum EDB2D36A0D90AE324B869C86183890F3. Tried another NewGRF with same GRF ID

The wording of this messages is IMO quite misleading. The file mentioned there (and the checksum) are those which are actually found. But they're not the one needed by the savegame. I tried with different versions of the ISR (a very bad newgrf with its incompatible versions, but same grfID), and it was always mentioned the file which was actually accessible by OpenTTD, but not the required MD5; that makes searching for the correct version difficult.

So... maybe this could or should also be a feature request to show the expected MD5 of the missing newgrf.

Tested OpenTTD Version: r17246

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3139
@DorpsGek
Copy link
Member Author

planetmaker wrote:

What I actually would like to see is something like

NewGRF 4A430002: Found file/with/path.grf with checksum EDB2D36A0D90AE324B869C86183890F3 while searching for checksum with same GRFID

This comment was imported from FlySpray: https://bugs.openttd.org/task/3139#comment6517

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The MD5 checksum that IS shown is the MD5 checksum of the file that is missing. Also the filename shown is the filename as stored in the savegame, not the filename of the newly loaded NewGRF.

I made a savegame with v0.6 of Japanese stations.

Then I removed that NewGRF and loaded the savegame:
dbg: [grf] NewGRF 45530400 (japanese_stations.0.6/jpstatsw.grf) not found; checksum 0CB1191FF67BA594F64B2934CFAEDF58

And later I downloaded version 2 and loaded the savegame:
dbg: [grf] NewGRF 45530400 (japanese_stations.0.6/jpstatsw.grf) not found; checksum 0CB1191FF67BA594F64B2934CFAEDF58. Compatibility mode on
dbg: [grf] Loading GRF 45530400 from japanese_stations.2.0/jpstationsw.grf

This comment was imported from FlySpray: https://bugs.openttd.org/task/3139#comment6520

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r17267

This comment was imported from FlySpray: https://bugs.openttd.org/task/3139

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek