Terkhen wrote:

There's an issue with this patch. Since CTRL+Drag automatically builds signals of the selected type along the railway, changing the selected signal gives the idea that it will build the type that has its button lowered, when it will actually build the originally selected type of signal.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123#comment6496

laurijh wrote:

That's interesting, I had no idea about that "autofill" functionality. Seems a bit strange that ctrl does completely different things with the same tool depending on whether you click or drag...

I guess there are two ways I could fix that in the patch; either disable the autofill and make ctrl simply switch the signal variant also when dragging, or keep the functionality and make the displayed variant switch back to normal when the drag is initiated. Which is preferable?

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123#comment6497

Terkhen wrote:

I can't live without autofill: it is incredibly useful when you are creating big train networks. Disabling existing features is not an option. Because of that I suggest implementing the second option.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123#comment6498

planetmaker wrote:

Disabling an existing feature is no option.
There are certainly means to detect whether the signals are dragged. Not displaying the other signal variant in that case should do the trick.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123#comment6500

laurijh wrote:

Ok, here's a new version. So now the patch does also a 3rd thing; shown variant reverts back to the "original" when dragging is detected (selection spans over more than one tile).

It was a bit trickier to get just right than I thought but after a couple of rewrites the new code ended up decently neat.

Attachments

• signal-gui-ctrl-r17206.patch (4.28 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123#comment6503

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/3123