Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ 2 commands, 1 variable, a commandline option & more for screensaver mode #306

Closed
DorpsGek opened this issue Aug 27, 2006 · 7 comments
Closed

+ 2 commands, 1 variable, a commandline option & more for screensaver mode #306

DorpsGek opened this issue Aug 27, 2006 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

GrimRC opened the ticket and wrote:

My patch adds (against svn R6159):

* gui_hide console cmd: hides almost all of the GUI
* gui_show console cmd: shows the GUI
* gui_spawn console var: controls whether the GUI elements 'spawn'; useful for a screensaver or demo mode, it prevents the main menu window, the toolbars and news items from spawning windows
* -z commandline option: takes a script file as an argument, to be executed instead of autoexec.scr

UndrawMouseCursor() is called by gui_hide, but doesn't seem to hide the mouse pointer for me.

openttd screensaver howto: http://wiki.openttd.org/index.php/Openttd_screensaver_howto

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/306
@DorpsGek
Copy link
Member Author

GrimRC wrote:

I forgot to mention, a screensaver.scr file is included. I've renamed it to screensaver.scr.example and made another patch.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment462

@DorpsGek
Copy link
Member Author

GrimRC wrote:

I've commented the patch better and improved it a little. It was made against R6179.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment469

@DorpsGek
Copy link
Member Author

GrimRC wrote:

Again, the screensaver.scr.example file got left out, so here's the updated patch against R6179, with the file included.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment470

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 6, 2006

GrimRC wrote:

I think this patch could be rewritten in a cleaner way, by modifying AllocateWindow() functions, and the like. Also, the new 'exec script file' openttd commandline option could be split out and implemented in a separate patch. I will do this eventually.

There are a couple of bugs with this patch that I've noticed. The status of the zoom buttons on the WC_MAIN_TOOLBAR window are not set properly when the window goes from hidden state to shown state. Also, an assertion is triggered sometimes in DoZoomInOutWindow(), because it depends (unreasonably) on WC_MAIN_TOOLBAR or WC_EXTRA_VIEWPORT existing. I've created a small patch to cleanup this function, and the link to this patch follows.

http://bugs.openttd.org/task/328

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment518

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2006

GrimRC wrote:

I've split-out the '-x script_file' command-line option to its own patch, available here: http://bugs.openttd.org/task/334

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment521

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 7, 2006

GrimRC wrote:

I realise how this can be better written now that I'm more familiar with the Openttd code, but I can't do it yet. Sometime.

This comment was imported from FlySpray: https://bugs.openttd.org/task/306#comment590

@DorpsGek
Copy link
Member Author

TrueBrain closed the ticket.

Reason for closing: Out of date

I hope you find the time to recreate this patch, but as you comment yourself: there are better ways. Feel free to reopen this patch when you have something new, would be cool :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/306

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek