planetmaker wrote:

Editing the cfg won't do any good as it doesn't impact a running game. But an option in the cheat menu "allow changing newgrf" might be a solution :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment6294

foobar wrote:

Why not? My suggestion is only about hiding the newgrf dialog in a running game, nothing more, nothing less. That needn't be stored in a savegame, a setting under [misc] in openttd.cfg is more than sufficient.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment6295

Rubidium wrote:

You're missing one major cause of changed NewGRFs: loading other people's savegames. Adding a setting to hide the NewGRF settings doesn't fix that at all.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment6489

foobar wrote:

Interesting...
I'm not completely aware of how it's currently handled (I don't load other people's savegames if they require certain newgrfs I know I don't have), but anyways:

If not all newgrfs are available and my suggested feature is disabled (the default) then deny loading the game.
If my feature is enabled, load the game and display the usual warning.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment6490

planetmaker wrote:

The attached patch introduces a new config-file-only setting "gui.scenario_developer". Unless this setting is enabled, one cannot load games anymore where one is missing the exact newgrfs. Also one cannot modify the newgrf config in an existing game. It is supposed to work analoguously to ai_developer, developer and newgrf_developer.

EDIT: the question arises whether loading of savegames and scenarios with compatible NewGRF shall be forbidden by this setting as well (as now) or whether this should be allowed or guarded by yet another config setting - this time maybe by a visible one in the adv. settings?

Attachments

• scenario_developer.diff (3.53 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8860

planetmaker wrote:

The attached patch applies on top of the previous patch and adds an option in the adv. settings which allows to enable and disable loading of savegames with compatible NewGRFs.

Thinking about it, the visible option to load games with compatible NewGRF seems desirable: if not present, many people might enable the scenario_developer, even if only loading a game where they have not the exact same version... and then they will be able to change newgrfs.

Attachments

• load_compatible.diff (4.42 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8861

planetmaker wrote:

After IRC discussion, a pre-condition for proper support is action14 support for minimum compatible version. Attached patches provide action14 support for "MINV". The savegames save the current newgrf version and a savegame has missing newgrf, if only newgrf with a higher MINV are found.

They probably can easily be made one commit, though, but provided for better reading as three separate patches.

Attachments

• save_newgrf_version.diff (1.46 KiB)
• minversion.diff (3.19 KiB)
• a14.diff (2.74 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8875

planetmaker wrote:

Updated version of 'minversion.diff'. The min_loadable_version was not copied when a compatible newgrf was loaded. Thanks for spotting, frosch.

Attachments

• minversion.diff (3.53 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8876

planetmaker wrote:

test newgrfs:
snowlindmod-1.0.0.zip: contains version 39, no min_loadable_version set (=0)
snowlinemod.grf: version 45, min_loadable_version=37

Attachments

• snowlinemod-1.0.0.zip (12.13 KiB)
• snowlinemod.grf (8.82 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8877

planetmaker wrote:

Yet another update of the two main patches. Thanks for the quick and extensive feedback.

Attachments

• minversion.diff (3.59 KiB)
• a14.diff (3.18 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8879

planetmaker wrote:

Hm... as usual. The obvious typo or omission after posting

Attachments

• minversion.diff (3.60 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8880

planetmaker wrote:

Update. Now only shows the newest version in the NewGRF selection from the main menu.

The introduced enum FindGRFConfigMode might (currently) be replaced by a boolean named 'get_newest', but the enum seems more extensible and possibly some subsequent refactoring, unifying the call of FindGRFConfig and putting some more logic in that routine; maybe adding a return parameter which tells whether an exact match, a compatible match, an incompatible match with the same grfID or no match was found.

Attachments

• minversion.diff (4.11 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8886

frosch wrote:

Grfs can now specify compatibility.

Alternative GUIs might still be nice :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8936

planetmaker wrote:

updated patch under http://devs.openttd.org/~planetmaker/scenario_developer.diff

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012#comment8938

planetmaker closed the ticket.

Reason for closing: Implemented

In various versions from r20918 to r21116

This comment was imported from FlySpray: https://bugs.openttd.org/task/3012