Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong strings in newgrf display on join game #2972

Closed
DorpsGek opened this issue Jun 10, 2009 · 6 comments
Closed

wrong strings in newgrf display on join game #2972

DorpsGek opened this issue Jun 10, 2009 · 6 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

The attached screen can be reproduced by joining a multiplayer server where you don't have all necessary newgrf but the missing one is on bananas.
How to reproduce:

  1. Select the server in the multiplayer window
  2. click "newgrf settings" in the multiplayer window
  3. click "find online content"
  4. select the missing grf and press "download" in the "content downloading" window
  5. press "ok" in the "downloading..." window after download finished
  6. press "cancel" in the "content downloading" window (kinda stupid name for the button, eh?)
  7. click "newgrf settings" in the multiplayer window

Problem: it does NOT seem to work 100% of the time in order to reproduce it, but in a good 80% of the cases or so.
Test binary linux-generic-i686

I tested with r16520 (as shown in screenshot) on our currently running publicserver.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2972
@DorpsGek
Copy link
Member Author

planetmaker wrote:

additional information: the "funny" text shown differed with every try when I tried to make this "how-to-reproduce" step-by-step list.
And don't close the newgrf list window inbetween.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972#comment6190

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Probable cause:

GRFConfig **orig_list; in NewGRFWindow
GRFConfig **list; in NewGRFAddWindow

(I reproduced the crash with the NewGRFAddWindow - game crashes when the window is open and new GRFs are downloaded)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972#comment6212

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I still have not been able to reproduce it on my machine :(

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972#comment6553

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Attached is valgrind output.
The "recently free'd place" can be invalid (freed at one place -> allocated at different place -> freed -> invalid read, reporting second free() instead of first one)

r17558

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972#comment6660

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Main screen -> Multiplayer -> choose a server where you have many missing GRFs (like # openttdcoop Public) -> NewGRF Settings -> Find Missing Content Online -> Select All -> Download -> Close -> close NewGRF Settings -> DON'T click "Refresh Server" -> NewGRF Settings -> strings are broken

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972#comment6664

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r17562

This comment was imported from FlySpray: https://bugs.openttd.org/task/2972

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek