Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion, if file gets removed and file list re-scanned #2967

Closed
DorpsGek opened this issue Jun 7, 2009 · 2 comments
Closed

Assertion, if file gets removed and file list re-scanned #2967

DorpsGek opened this issue Jun 7, 2009 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jun 7, 2009

planetmaker opened the ticket and wrote:

Certainly a bit minor thing, but consider:

from the title screen open the newgrf selection window
select a file
from outside OpenTTD delete that file
hit apply changes
Result: ...trunk/src/fileio.cpp:340: failed assertion `f != NULL'

It's the same for tar'ed grf or plain grf.

The same happens, if you just press "rescan file list" button, even if the deleted file is not selected in any way.

tested with r16533 and 0.7.0

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2967
@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 9, 2009

Yexo wrote:

With "rescan file list" the assert only happens for NewGRFs that are in a tar file.
With "apply selection" after adding a deleted newgrf the following can happen:
- For NewGRFs in a tar file: the above mentioned assert.
- For NewGRFs not in a tar file: OpenTTD exists with usererror("NewGRF file is missing '%s'", c->filename); (newgrf.cpp:6216)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2967#comment6187

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r16590

This comment was imported from FlySpray: https://bugs.openttd.org/task/2967

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek