Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detection of newer base graphics set not working #2950

Closed
DorpsGek opened this issue Jun 2, 2009 · 3 comments
Closed

detection of newer base graphics set not working #2950

DorpsGek opened this issue Jun 2, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jun 2, 2009

planetmaker opened the ticket and wrote:

Put the two attached basegraphics sets (which call themselves OpenGFXTest) in e.g. content_download/data and select that in the game settings. Testing with r16502 on linux or mac (and an older nightly in the r164xx range) I only get offered one choice (which is ok), but this one choice is the older version of the basegraphics set (r34 as opposed to r45). I expect to see offered the newer replacement :) The newer replacement is used satisfactorily, if I delete the old versions from the grf directory.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2950
@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 2, 2009

planetmaker wrote:

2nd basegraphics file

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2950#comment6151

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 2, 2009

Rubidium wrote:

First of all: we won't fix this what you see as a bug. What you are seeing is a 'feature' that makes sure we don't add duplicate tars (tars with a different path that are the same). How to determine you have seen the file already? Simple, just check if you know the path already. For tar files it looks, for various reasons, at the path within the tar.

For OpenGFXtest there is not 'path' within the tar except the filename of the files, thus both tars are considered to be the same. What will solve your problem (and what is normal use for tars) is to put the files within a directory in the tar. For example OpenGFXTest-nightly-r45M/opengfx.obg. This will also put the files in different directories once you extract the tar file instead of overwriting eachother.

On the other hand... the graphics selection is based on the name of the graphics set, so there shouldn't be duplicate graphics set names in the selection in the GUI.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2950#comment6152

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 2, 2009

Rubidium closed the ticket.

Reason for closing: Won't fix

Add directories to the tar. The graphics set selection is only showing one version of the set too.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2950

@DorpsGek DorpsGek closed this as completed Jun 2, 2009
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek