Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradual loading at stations patch #288

Closed
DorpsGek opened this issue Aug 18, 2006 · 3 comments
Closed

Gradual loading at stations patch #288

DorpsGek opened this issue Aug 18, 2006 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Maedhros opened the ticket and wrote:

This patch enables gradual loading as a patch option. If enabled, it will try to load cargo up to the load amount defined by newgrf callback 12, action 0 property 7, or the default values of 5 for trains and road vehicles, 10 for ships, and 20 for aircraft every 25 ticks. When there is no cargo waiting or the vehicle is full it will leave the station. Full load and unload aren't affected, except that the cargo enters and exits the vehicle more slowly.

The patch was made against r5934.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/288
@DorpsGek
Copy link
Member Author

Maedhros wrote:

Update to fix a few problems:

* Unloading to a station that didn't accept the cargo didn't work past the first $load_amount, and then it added the wrong amount to the station anyway.
* If the "Improved loading algorithm" patch was enabled, vehicles wouldn't load while another train was in the station. It now checks to see if Full Load is in the orders so vehicles without it can load if another is in the station.
* If the "Leave station when any cargo is full" patch was enabled, vehicles would leave the station when one cargo type was full. It now checks if Full Load is in the orders so they carry on loading the other cargo if it's available and they're not set to Full Load.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/288#comment410

@DorpsGek
Copy link
Member Author

Maedhros wrote:

Right, this should be the final bug-fix update - there's now a v->cargo_unloading boolean so that once a vehicle has been unloaded fully, it won't try to unload anything else that's just been loaded.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/288#comment411

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 6, 2006

Maedhros closed the ticket.

Reason for closing: Implemented

Now in trunk, as of r7326.

This comment was imported from FlySpray: https://bugs.openttd.org/task/288

@DorpsGek DorpsGek closed this as completed Dec 6, 2006
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek