Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection lost messages for every disconnect #2880

Closed
DorpsGek opened this issue May 4, 2009 · 3 comments
Closed

connection lost messages for every disconnect #2880

DorpsGek opened this issue May 4, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 4, 2009

dihedral opened the ticket and wrote:

the 'connection lost' message ALWAYS appears after any type of disconnect.
may it be a kick or leaving the game normally.

i have also found out that NetworkCloseClient() is called twice, once for leaving, and once from NetworkClientSocket::CloseConnection() (in src/network/core/tcp_game.cpp)

*** Mr. Twisty22 has left the game (leaving)
*** Mr. Twisty22 has left the game (connection lost)

my logs show this behavior since r15985, however r15966 was not able to be tested correctly due to a bunch of crashes. the last nightly with normal behavior was r15964

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2880
@DorpsGek
Copy link
Member Author

dihedral wrote:

only fixed for client quit, not for kick or ban


This comment was imported from FlySpray: https://bugs.openttd.org/task/2880#comment6245

@DorpsGek
Copy link
Member Author

dihedral wrote:

perhaps if the same line is added to sending PACKET_SERVER_ERROR ?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2880#comment6246

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed


This comment was imported from FlySpray: https://bugs.openttd.org/task/2880

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant