OpenTTD

Tasklist

FS#2880 - connection lost messages for every disconnect

Attached to Project: OpenTTD
Opened by Nathanael Rebsch (dihedral) - Monday, 04 May 2009, 09:05 GMT
Last edited by Remko Bijker (Rubidium) - Tuesday, 23 June 2009, 20:34 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version 1.0.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

the 'connection lost' message ALWAYS appears after any type of disconnect.
may it be a kick or leaving the game normally.

i have also found out that NetworkCloseClient() is called twice, once for leaving, and once from NetworkClientSocket::CloseConnection() (in src/network/core/tcp_game.cpp)

*** Mr. Twisty22 has left the game (leaving)
*** Mr. Twisty22 has left the game (connection lost)

my logs show this behavior since r15985, however r15966 was not able to be tested correctly due to a bunch of crashes. the last nightly with normal behavior was r15964
This task depends upon

Closed by  Remko Bijker (Rubidium)
Tuesday, 23 June 2009, 20:34 GMT
Reason for closing:  Fixed
Comment by Nathanael Rebsch (dihedral) - Thursday, 18 June 2009, 21:25 GMT
  • Field changed: Percent Complete (100% → 0%)
only fixed for client quit, not for kick or ban
Comment by Nathanael Rebsch (dihedral) - Thursday, 18 June 2009, 21:26 GMT
perhaps if the same line is added to sending PACKET_SERVER_ERROR ?

Loading...