Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique station name should be per-player, not per-game #2867

Closed
DorpsGek opened this issue Apr 26, 2009 · 3 comments
Closed

Unique station name should be per-player, not per-game #2867

DorpsGek opened this issue Apr 26, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

bilbo opened the ticket and wrote:

Today on multiplayer server I tried renaming a station and I got "name must be unique" error. I've discovered someone else started using exactly the same naming scheme as me (It was partially my fault, as I explained it to him earlier), thus disallowing me to use these names myself.

I think names should be unique only within stations (and vehicles) of one player, not within all stations (vehicles) in the game. I see no problem with vehicles of different players having same name, though for stations this could cause little confusion when they are mentioned in the news.

So alternative for redoing the news could be by keeping the uniqueness requierements, but automatically adding company prefix to custom station names, that would be specified in company window (which would have to be unique).

Reported version: 0.7.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2867
@DorpsGek
Copy link
Member Author

SmatZ wrote:

Is it worth it? What about station list for spectators?
When you merge companies, do you want to have stations renamed? Or reset to default name?

This could as well be extended to vehicle names and group names.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2867#comment5977

@DorpsGek
Copy link
Member Author

bilbo wrote:

There is also some code to "de-duplicate" the name used when cloning wehicle. This code could be used then to autorename vehicles/groups on merger when necessary.

Question is - do vehicle names really nedd to be unique? Would having five trains named "coal express" harm anything?

As for the station names - with the company prefix, I'll see my names without that prefix (it will be automatically added when renaming and removed when displaying). Spectators would see all prefixes.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2867#comment5979

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: more than 5 years old, and not a current goal for OpenTTD, so closing. If this offends, discuss with andythenorth in irc. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2867

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant