Meush wrote:

Sorry for a typo. This version works properly:

Attachments

• idle_industries.patch (3.27 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment412

Meush wrote:

I'm sorry I attached the wrong file. This is the proper patch:

//And please, fix the editing. I'd be grateful for one that makes me able to edit my tasks... I have the right permissions, but double-click doesn't work. I'm using Mozilla FF 1.5.0.6, WinXP.

Attachments

• idle_industries2.patch (3.31 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment417

Mateo wrote:

Shouldn't this setting be in the Message Settings window rather than Configure patches window?

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment449

Meush wrote:

IIRC there widget limit in message settings has been already hit and hacks are used.
Anyway, what do you propose? To change none/summary/full to something else? To add a checkbox below?

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment450

Mateo wrote:

From usability point of view, I would modify the message options screen with the following changes:
- Leave 'Economy changes' as it is, but it's used to display stuff like inflation etc.
- New option: 'Production changes of exploited industries": Off/Summary/Full
- New option: 'Production changes of idle industries": Off/Summary/Full

I personally don't care about any production changes, but I don't want to turn off the 'economy changes' because it may display some other important stuff. BTW, what kind of other messages are display with the current 'economy changes' selection? I can't remember.. The same goes to "General information" also..

If the widget limit is a problem, then probably it's better to wait till it's fixed (I think there's already a development branch for it)..

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment452

Meush wrote:

That's right, a fix to kill the limit of widget is in progress.
Your idea seems to be allright, but I'd suggest my patch as temporart behaviour, because noone knows how long will it take to finalize the widget fix.
The other economical news are euro currency and crash on the stock market, probably some news more, too.

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment453

TrueBrain wrote:

This really shouldn't be done via patches, but via the news system, which can handle more news settings by now. Recently (as in: within the last 2 months) I did it once for some industry related things, so maybe you can revive this patch and make it similar to that? Would be useful!

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment1862

Meush wrote:

It would be great if you could point me the changes, then I'll willingly do the job. That would be a stimulus for me to go coding and see how does OpenTTD in C++ look like. It's been such a long time.

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment1863

TrueBrain wrote:

I think http://svn.openttd.org/trac/changeset/9097 should get you on the way. Of course not all of that patch is relevant to you, but it has the right pieces of code.

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment1864

Meush wrote:

Done.
How about separating industry changes from "economy changes" completly? What do you think about making NT_ECONOMY handle production changes only (it would be nice to rename it and change descriptor in news setting) and moving €uro introduction and world recession related news (the only three news items that are NT_ECONOMY) to "General information"?

Attachments

• idle_industries2.patch (8.04 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment1911

Alberth wrote:

FYI: Your patch seems to be incomplete. When adding a news category, you not only need to update the _news_display_name array, but also the _news_sounds and the _news_items_age arrays.

This comment was imported from FlySpray: https://bugs.openttd.org/task/285#comment2212

Rubidium closed the ticket.

Reason for closing: Out of date

Due to r11442 and #1326.

This comment was imported from FlySpray: https://bugs.openttd.org/task/285