Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Add conditional order "skip with certain probability" #2840

Closed
DorpsGek opened this issue Apr 14, 2009 · 3 comments
Closed

[patch] Add conditional order "skip with certain probability" #2840

DorpsGek opened this issue Apr 14, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

bilbo opened the ticket and wrote:

This patch adds conditional order to jump with certain probability

Useful with multiple bus/tram stations or airports, when some of them produce significantly less passengers than others. It is possible with the patch to set probability to skip that station based on that.

For example, with 3 stations (A,B,C) that produces X passengers/month and D that produces only X/3 passengers, orders can be:

  1. goto A
  2. goto B
  3. goto C
  4. with 66 percent probability, jump to order 1
  5. goto D

and only approximately one third of the vehicles will go to D.

When using shared orders and the cargo production in station D later changes (towns don't grow uniformly...), it is possible later to just adjust the probability of skipping easily when managing vehicles

The feature is taken from "more conditional orders" patch, but unlike that patch, the skipping is truly random and not deterministic.

Testet both in single and multiplayer (2 clients connected to 1 dedicated server) and I've not observed desyncs or any other problems.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2840
@DorpsGek
Copy link
Member Author

SmatZ wrote:

I don't see the reason for savegame version bump.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2840#comment5934

@DorpsGek
Copy link
Member Author

bilbo wrote:

If there exist an order with the new condition (OCV_PERCENT) for any vehicle (and it get saved), it won't be understood if it is loaded on openttd without this patch. Therefore the savegame version bump, as the saves won't be backwards compatible once this feature is added.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2840#comment5935

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2840

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant