Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny patch to improve ship movement #2823

Closed
DorpsGek opened this issue Apr 10, 2009 · 3 comments
Closed

Tiny patch to improve ship movement #2823

DorpsGek opened this issue Apr 10, 2009 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

hackalittlebit opened the ticket and wrote:

Hello Developers

Tiny patch to improve ship movement.
See post on forum for details.
http://www.tt-forums.net/viewtopic.php?f=33&t=42758

Thanks for your efforts.

Regards HackaLittleBit

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2823
@DorpsGek
Copy link
Member Author

hackalittlebit wrote:

How the code works is very simple.
It looks 2 tiles ahead (new tile + 1)when ship found on that tile turn to left side to avoid collision.
only works when 3way track bit set. (In theory, you should have space to move).
other track bit combination's are ignored.
The whole thing happens only when entering new tile and after the trackfinder has determined the route.
Version 16021 cleaned code plus little bugfix
Regards

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2823#comment5911

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Hello Hans,
the intention is certainly nice, but it causes havoc in games like http://www.openttdcoop.org/wiki/PublicServer:Archive_-_Games_121_-_130# gameid_122 or in 1 tile wide canals. It seems you forgot about aqueducts. It seems to be using HasVehicleOnPos in a wrong way, possibly causing desyncs.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2823#comment5953

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Won't implement

Making ships non-coliding makes them unusable.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2823

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant