Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "full load major cargo" to orders. #2806

Closed
DorpsGek opened this issue Apr 4, 2009 · 9 comments
Closed

Add "full load major cargo" to orders. #2806

DorpsGek opened this issue Apr 4, 2009 · 9 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 4, 2009

bilbo opened the ticket and wrote:

There are situations, where "full load" and "full load any" is not sufficient for optimal operation.

In case, where vehicle have "major cargo" (for example 400 passengers in airplane) and minor cargo (50 bags of mail in same airplane), you usually want to wait for major cargo (passengers) and perhaps some mail. "Full load" will cause to wait for mail too (which can be bad if the mail "runs out", especially if it is picked up from station by other means), "full load any" can cause the planes in other situation to load all the mail, perhaps few passengers and then leave airport mostly empty.

The worst case is if you use SH125 to transport oil. Since the engine can't be refitted to oil, you keep it as is (capacity 2x4 bags of mail), set "full load any" (we don't wait to load any mail, right?) and off you go .... but if the station from which you take oil does somehow provide mail (like if some city later grows to vicinity of your oil-loading station), "full load any" will cause the engine to load 8 bags of mail, some oil (usually much less than full capacity) and depart. Down goes the profit on that line...

Therefore I suggest adding "full load major cargo" in addition to current two types of full load, which will wait for loading the cargo that have most capacity in the vehicle.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2806
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 4, 2009

SmatZ wrote:

You can refit the SH125 to coal, so it won't full load mail.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment5891

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2009

Belugas wrote:

What if both cargo have the same importance and "load fill major" is set?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment5893

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 9, 2009

bilbo wrote:

If both cargo compartments are of same size, then the load major should wait for either of them - like in load any. But if one of the cargo compartments is larger, it should wait for it and do not depart if only the smaller one is filled.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment5910

@DorpsGek
Copy link
Member Author

mirqus wrote:

Here is an implementation of this idea. Against trunk 18513. This modifies how load flags are assigned, but has a conversion layer in AI API so that current AIs don't need to be updated (and so can't benefit from the change).

Theres a problem in defining 'larger' here. I chose larger as in more total capacity. One might want just counting wagons, someone else might say that a cow is larger than passenger and another - the inverse.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment7060

@DorpsGek
Copy link
Member Author

mirqus wrote:

Updated to not confuse users when using ctrl+clicks on aircraft full load - now it assumes 'full load primary' as that was efectively how 'full load any' previously worked for them. The same goes for AI compatibility wrapper.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment7066

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2012

ComLock wrote:

I would be even nicer if one could specify cargo type: Full load passengers

Example:

Consider two train stations which are only used to transfer cargo from/to road vehicles.
At station A (trucks deliver oil and pickup chemicals)
At station B (trucks pickup oil and deliver chemicals)
For a single train that has both oil and chemical vagons I would like to issue these orders:

  1. Go non-stop | to Station A | and Unload chemicals | then Full load oil
  2. Go non-stop | to Station B | and Unload oil | then Load chemicals if avaiable

ASFAIK this is not currently possible using a single train without refitting (maybe optimize refitting with conditional order?)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment11661

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 7, 2012

ComLock wrote:

See #5299


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment11666

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2017

andythenorth wrote:

See #5357 also. Orders could use a total rework, but that's not a current goal for OpenTTD.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806#comment14497

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2806

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant