Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad name for oilrig #2785

Closed
DorpsGek opened this issue Apr 2, 2009 · 6 comments
Closed

Bad name for oilrig #2785

DorpsGek opened this issue Apr 2, 2009 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 2, 2009

mizipzor opened the ticket and wrote:

An oilrig was just spawned in my game. The name it got was "Fort Ponfingford Mines". All other rigs are named "... Oilfield" and I guess the intended behaviour is the same for this one as well.

Attached is a screenshot and a save.

Attachments

Reported version: 0.7.0
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/2785
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2009

mizipzor wrote:

The year when this happened was 2024. I have another save from 2021. I dont know if the industry spawning is deterministic but please tell if you want that save as well to step through the code in debugging.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785#comment5880

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2009

mizipzor wrote:

If I load the save from 2021 and let it run, the same industries are not spawned at the same places. I take it as the industry spawning is not deterministic. Two other industries spawned though, a rig and a factory, but both were correctly named.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785#comment5881

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2009

frosch wrote:

There is already an oilrig named "Fort Ponfingford Oilfield". OpenTTD will not generate duplicated names.

It picks "Mines" because it is not yet used, and the oilrig is an extractive industry that produced at least one non-liquid cargo. Namely "passengers"... :/


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785#comment5883

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2009

mizipzor wrote:

Okey, its not a bug, the system works as expected. But there must be a better solution than naming the oilrig "mines". Wouldnt "oilrig 2" work? Or do it have to be one of the hardcoded strings? But in that case, what happens if enough oilrigs spawn close to a certain town, and the game runs out of strings?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785#comment5886

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Maybe we should 'exclude' cargo that is in the passenger and/or mail class.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785#comment5915

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r16029


This comment was imported from FlySpray: https://bugs.openttd.org/task/2785

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant