Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] Port hopelessly outdated #2782

Closed
DorpsGek opened this issue Apr 1, 2009 · 15 comments
Closed

[OSX] Port hopelessly outdated #2782

DorpsGek opened this issue Apr 1, 2009 · 15 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 1, 2009

Rubidium opened the ticket and wrote:

The OSX port is at least missing:
- entering of complex characters fails (Chinese, Japanese, CJK), fee #2484

Reported version: trunk
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/2782
@DorpsGek
Copy link
Member Author

Rubidium wrote:

macos.mm is an utter mess:
- it doesn't show NewGRFs when they exist, though it says there are no NewGRFs
- it doesn't show the right OSX version, even though there are ways to get the correct one
- it doesn't show all CPUs and in case of an unknown CPU is just says unknown instead of (also) giving the numeric value so we can look it up
- it doesn't comply with coding style in lots of places
- there are typos in the GUI strings, e.g. presists

The other files in os/macosx/ fail on coding style and sanity too!


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6552

@DorpsGek
Copy link
Member Author

planetmaker wrote:

The attached patch generalizes and cleans up a bit the CPU detection by using the CPU tables in the available header files, after checking a range of CPUs more directly (as the CPU tables in the header files are not new...).

The patch could be made very small, if the first attempt to get a better CPU description is dropped; it would then condense to the part in GetProcessor() at the very bottom guarded by if (err) {...}

The patch builds upon the version detection patch http://bugs.openttd.org/task/3156/getfile/4663/fix_osxversion_detection_r17291.diff

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6560

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Attached updated patches for partially cleaning up src/os/macosx/macos.mm

1st part: version_detection.diff
2nd part: cputype.diff

3rd parg, still a TODO: adding the newgrf information as they obviously once were available. Are they actually in such case reported for other OS and where should I then look for that?

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6562

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Another update of the cputype diff, fixing further issues with comments in the code (and one left-over also from the version_detection).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6564

@DorpsGek
Copy link
Member Author

planetmaker wrote:

yet another iteration in small fixes, mainly thanks to Yexo pointing them out.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6565

@DorpsGek
Copy link
Member Author

planetmaker wrote:

and another one :-)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6566

@DorpsGek
Copy link
Member Author

Yexo wrote:

Some changes to apply to coding style (and removing some coding style fixing at places unrelated to those patches).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6567

@DorpsGek
Copy link
Member Author

planetmaker wrote:

works for me. Attached another version of version_detection with yet another 4 lines of coding style improvements

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6568

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 4, 2009

planetmaker wrote:

following this days discussion, this is a leaner version of the MacOS version detection.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6592

@DorpsGek
Copy link
Member Author

michi_cc wrote:

#3223 has a MIDI player implemented with CoreAudio, i.e. not using QuickTime.

I've also collected all the so far proposed OS X patches at:
http://www.icosahedron.de/cgi-bin/gitweb.cgi?p=ottd_osx.git


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6712

@DorpsGek
Copy link
Member Author

michi_cc wrote:

The two attached patches try to improve the configure script with regards to the
minimal OSX version and the detection of the SDK and the usable features.

The second one applies on top of the first one. Especially the second one could use
testing with different options for the configure script. All optional features should
be properly detected, but maybe I missed something.

The git branch is updated as well.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6760

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 5, 2009

michi_cc wrote:

version_detection and the two configure patches are in trunk now.
CPU type was made obsolete by providing a implementation of the common CrashLog system.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6788

@DorpsGek
Copy link
Member Author

michi_cc wrote:

Automatic font detection is present since r17794.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment6840

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 1, 2010

ln wrote:

#3194 and #2585, the two most important unfixed ones are both related to fullscreen video. I wonder if they could be fixed by using the Quartz video implementation in fullscreen too (now used only for window mode). It would also have some other advantages over the current implementation.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782#comment7185

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Not a bug

Can't be bothered to update this anymore; just check "waiting for porter" stuff prefixed by [OSX].


This comment was imported from FlySpray: https://bugs.openttd.org/task/2782

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant