Yexo wrote:

This was an explicit design decision for the API and won't be changed now. Just getting a list of StationIDs of your opponents stations isn't usefull, as all API functions have @pre IsValidStation(station_id), and IsValidStation returns false for stations not owned by you. Changed IsValidStation could break current AIs, so that's not going to happen. Therefor there is no easy solution to allow querying more information about your opponents.

I'm marking this very low severity, as it won't change now but we might want to rethink about it in the future.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2776#comment5866

bilbo wrote:

There could be switch of modes (
ExamineOnlyMyOwnStationsAndVehicles (being default) and ExamineAllStationsAndVehicles) that will switch the isValidStation/isValidVehicle/etc... to stop checking for owner (or only check the owner for attempts to modify the given station/vehicle) for AI that called it.

This won't break any current AI's (they won't know of the modes, so they won't switch to "see all stations" mode and they won't know about the new functions so they won't call them) and AI's that know of the modes can use it to examine the opponents. And of course they have to be aware of consequences and know that not all stuff is theirs. In that case, perhaps in AIVehicle and AIStation some function to ask about owner could be added for completeness.

So if AI receives AIEventStationFirstVehicle for opponents vehicle, any attempts to discover whose vehicle or station it is will fail with "invalid vehicle/station"?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2776#comment5868

Yexo wrote:

"So if AI receives AIEventStationFirstVehicle for opponents vehicle, any attempts to discover whose vehicle or station it is will fail with "invalid vehicle/station"?"

An AI will never receive that events for vehicles from other companies.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2776#comment5875

bilbo wrote:

I got idea how this could be done relatively easily without breaking the API.

Add AIController.SetFilter(FilterFlags)

where FilterFlags would be be bitflags of:

SEE_OWN_VEHICLES - Allow seeing/querying my own vehicles
SEE_OTHER_VEHICLES - Allow seeing/querying my own vehicles
SEE_OWN_STATIONS - Allow seeing/querying my own stations
SEE_OTHER_STATIONS - Allow seeing/querying my own stations
EVENT_OWN - Allow receiving events about my vehicles/stations/etc...
EVENT_OTHERS - Allow receiving events about opponents vehicles/stations/etc...

Default would be (SEE_OWN_STATIONS | SEE_OWN_VEHICLES | EVENT_OWN)

Every company will have field with its filter.

And checks like "v->owner == _current_company" in IsValidVehicle could be replaced by some inline function that will check also with the filter:
->
"CheckOwnerFilter(v->owner == _current_company, filter)"

inline bool CheckOwnerFilter(bool my_vehicle,Filter filter) {
if (my_vehicle) return (Filter & VEHICLE_MINE) else return (Filter & VEHICLE_OTHERS);
}

Also, maybe adding few functions to query owner to objects that don't have them (like AIBridge have no method to query ownerID) would be useful if tyhis is implemented.

Overall the change will be relatively minimal and AI not knowing of it will behave as before.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2776#comment5951

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: more than 5 years old, and not obvious what should be done with this next, so closing. If this offends, discuss with andythenorth in irc. Thanks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2776