Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviour with missing/corrupted sample.cat #2761

Closed
DorpsGek opened this issue Mar 24, 2009 · 1 comment
Closed

Different behaviour with missing/corrupted sample.cat #2761

DorpsGek opened this issue Mar 24, 2009 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

foobar opened the ticket and wrote:

I noticed an inconsistency regarding the sample.cat file. I tested on Vista x86 using 0.7.0 RC1 and RC2

If the sample.cat file is completely missing, an error message is issued (nocat.PNG) with the only option to terminate the game.

With a dummy/empty sample.cat file in place, a warning is issued (emptycat.PNG) with the option to continue despite the corrupted file or to terminate the game.

It would be grand if the same options could be provided if sample.cat is missing as when it's corrupted. That way, there's no need to create an empty sample.cat file before starting the game for the first time.

This will help a lot of new users, having no (legal) access to the TTD files wanting to play the game using the OpenGFX base set. I tried providing an empty sample.cat file with the OpenGFX tarball, but the game only recognises the original sample.cat when it's tarred. A tarred empty sample.cat file (either packed with OpenGFX or in a seperate tarball) isn't recognised.

So having a fake tarred sample.cat regcognised instead of changing the error/warning message behaviour would work for me as well. Something that needs to be addressed then is what to do when both the original and a dummy sample.cat are found.

Thanks in advance,
FooBar

Attachments

Reported version: 0.7.0-RC2
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/2761
@DorpsGek
Copy link
Member Author

Belugas closed the ticket.

Reason for closing: Won't implement

That would lead to problems like : how come I do not have sounds? users do not really care about warnings. Errors are different. So if you do not have sample.cat, it means that you have not all the required data to run the game properly.
IF you have an empty one, it means that you have made something to remove the problem encountered when there was no sample.cat. Therefor, OpenTTD acknowledge that there is a problem, but the problem is surely generated by the user, and that user is well aware of what has been done.
We talked about it, and that's what has came up.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2761

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant