Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckMinActiveClient not called when using menu "New Company" #2745

Closed
DorpsGek opened this issue Mar 19, 2009 · 5 comments
Closed

CheckMinActiveClient not called when using menu "New Company" #2745

DorpsGek opened this issue Mar 19, 2009 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

muxy opened the ticket and wrote:

Hi,
Using OpenTTD 0.7.0-RC1 as dedicated server on linux.
Using the min_active_client=1 in the openttd.cfg.

Connecting to the server as spectator.

The CheckMinActiveClients() from network.cpp is not called when using the menu "New Company".

The game remains paused

Reported version: 0.7.0-RC1
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2745
@DorpsGek
Copy link
Member Author

muxy wrote:

I fix this bug by adding a call to CheckMinActiveClients() when the server sends a DoCommand (PACKET_SERVER_COMMAND) to the clients only if the command sent is a CMD_COMPANY_CTRL.

The DEBUG call can be removed if not necessary...

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2745#comment5806

@DorpsGek
Copy link
Member Author

glx wrote:

What is the pause_on_newgame value ?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2745#comment5807

@DorpsGek
Copy link
Member Author

muxy wrote:

pause_on_newgame is set to false.

On new game or when starting the server, due to min_active_client, before generating the map, game is paused

This comment was imported from FlySpray: https://bugs.openttd.org/task/2745#comment5808

@DorpsGek
Copy link
Member Author

glx wrote:

I can reproduce it only with pause_on_newgame true.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2745#comment5809

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r15773

This comment was imported from FlySpray: https://bugs.openttd.org/task/2745

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek