Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible rail types are not by definition compatible in both ways #2685

Closed
DorpsGek opened this issue Feb 25, 2009 · 1 comment
Closed

Compatible rail types are not by definition compatible in both ways #2685

DorpsGek opened this issue Feb 25, 2009 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Swallow opened the ticket and wrote:

If rail type A is compatible with rail type B, rail type B is not by definition compatible with A. For example: normal trains may drive on 'high-speed rail', but high-speed trains not on normal rail. Of course this requires NewGRF railtypes.

A location where this may become an issue is the GetTrainForReservation function in pbs.cpp Here, the compatible rail types of the start tile instead of those of the vehicle are used. This may be logical, since the vehicle isn't known yet, but it can produce errors when the compatibility of the rail type differs from that of the vehicle.

Currently, this is of course a non-issue. It may however become one when NewGRF-controlled rail types are introduced. Therefore I wanted to file a bug report here, so the latent problem would not be forgotten.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2685
@DorpsGek
Copy link
Member Author

Belugas closed the ticket.

Reason for closing: Invalid

Although the intention is honourable, it might be better to come up with hard facts instead of speculations.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2685

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek