Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport Tunnel Building #2629

Closed
DorpsGek opened this issue Feb 12, 2009 · 5 comments
Closed

Viewport Tunnel Building #2629

DorpsGek opened this issue Feb 12, 2009 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

hackalittlebit opened the ticket and wrote:

Feature: Focus viewport onto tunnel end by pressing Ctrl when building tunnel.
will only work when viewport allready open.
Changes: Viewport has now EYE to focus main screen to viewport center.

Code has no influence on original game play behavior.

Regards Hans

Attachments

Reported version: 0.6.3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2629
@DorpsGek
Copy link
Member Author

hackalittlebit wrote:

See foto

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2629#comment5572

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2009

Rubidium wrote:

This only works when a viewport with number 0 is opened; e.g. when I open 2 viewports and open the first.

Furthermore, which is a much bigger problem: you're using _ctrl_pressed in the command handling code. This code is called also when someone else builds a tunnel, meaning that if you have the first viewport open, you have ctrl pressed (for one of the many reasons) and someone else builds a tunnel your first viewport will be redirected.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2629#comment6600

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2009

hackalittlebit wrote:

Thanks Remko for having a look at it.

I had a look at the code last night and made some improvements
the problem that I still have to solve is finding the 'first' open viewport of the user that pressed the Ctrl key.
finding the viewport I do with a while loop but I have no clue how the relation user - window works in openttd.
I will need some time to discover if that is posible.

Anyhow thanks

Hackalittlebit

P.S will post updated patch tonight


This comment was imported from FlySpray: https://bugs.openttd.org/task/2629#comment6620

@DorpsGek
Copy link
Member Author

hackalittlebit wrote:

Here is revised Patch

I am not shure if it will work in multi player situation.
Please have a look at it

Regards HackaLittleBit

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2629#comment6628

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2629

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant